src/hydrogen.cc - Issue 1140743004: Generalize builtins inlining flag to allow forced inlining of any function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1140743004: Generalize builtins inlining flag to allow forced inlining of any function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 4f04580376789ec692104af8d6f914bc62b53634..1665c562d2c988cb8b0fab7534ad9764a33a0f87 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7951,8 +7951,11 @@ int HOptimizedGraphBuilder::InliningAstSize(Handle<JSFunction> target) {

Handle<SharedFunctionInfo> target_shared(target->shared());

// Always inline builtins marked for inlining.

Michael Starzinger 2015/05/20 10:37:35 nit: Comment is outdated now.

danno 2015/05/20 12:19:19 Done.

+ if (target_shared->force_inline()) {

+ return 0;

+ }

if (target->IsBuiltin()) {

- return target_shared->inline_builtin() ? 0 : kNotInlinable;

+ return kNotInlinable;

}

if (target_shared->IsApiFunction()) {

« src/compiler/js-inlining.cc ('K') | « src/compiler/js-inlining.cc ('k') | src/math.js » ('j') | no next file with comments »