Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140743004: Generalize builtins inlining flag to allow forced inlining of any function (Closed)

Created:
5 years, 7 months ago by danno
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Generalize builtins inlining flag to allow forced inlining of any function Committed: https://crrev.com/218e101297dc21f674499731b7119e339ca157e1 Cr-Commit-Position: refs/heads/master@{#28510}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -58 lines) Patch
M src/collection.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler.h View 1 2 chunks +3 lines, -10 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M src/math.js View 1 chunk +12 lines, -12 lines 0 comments Download
M src/objects.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danno
PTAL
5 years, 7 months ago (2015-05-19 21:12:51 UTC) #2
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298 src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining && !function->shared()->force_inline()) ...
5 years, 7 months ago (2015-05-20 10:37:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140743004/40001
5 years, 7 months ago (2015-05-20 12:17:42 UTC) #6
danno
Feedback addressed https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298 src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining && !function->shared()->force_inline()) { ...
5 years, 7 months ago (2015-05-20 12:19:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 12:48:09 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 12:48:24 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/218e101297dc21f674499731b7119e339ca157e1
Cr-Commit-Position: refs/heads/master@{#28510}

Powered by Google App Engine
This is Rietveld 408576698