Source/modules/webaudio/AudioContext.h - Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.h

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using raw pointer again with the manual reference management. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webaudio/AbstractAudioContext.cpp ('k') | Source/modules/webaudio/AudioContext.cpp » ('j') | Source/modules/webaudio/OfflineAudioContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.h

diff --git a/Source/modules/webaudio/AudioContext.h b/Source/modules/webaudio/AudioContext.h

index 6f5b7cda11aeaad2a57482bdb9d6e55180b5f338..01d1f60c96c1c41c88bcedc36dd6bc7f08cb7e99 100644

--- a/Source/modules/webaudio/AudioContext.h

+++ b/Source/modules/webaudio/AudioContext.h

@@ -26,11 +26,14 @@ public:

DECLARE_VIRTUAL_TRACE();

ScriptPromise closeContext(ScriptState*) final;

- bool isContextClosed() const final;

ScriptPromise suspendContext(ScriptState*) final;

ScriptPromise resumeContext(ScriptState*) final;

+ // This is to implement the pure virtual method from AbstractAudioContext.

+ // CANNOT be called on OfflineAudioContext.

+ ScriptPromise suspendContext(ScriptState*, double) final;

+ bool isContextClosed() const final;

bool hasRealtimeConstraint() final { return true; }

protected: