Source/modules/webaudio/AudioDestinationNode.h - Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioDestinationNode.h

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Resolving the render thread issue (WIP) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/AudioDestinationNode.cpp » ('j') | Source/modules/webaudio/OfflineAudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioDestinationNode.h

diff --git a/Source/modules/webaudio/AudioDestinationNode.h b/Source/modules/webaudio/AudioDestinationNode.h

index 142ee084e4dcf33e042f448fb9d55c34eb478e3a..9c840644b697aafa1aa0ba14a16e5c9ea322cf58 100644

--- a/Source/modules/webaudio/AudioDestinationNode.h

+++ b/Source/modules/webaudio/AudioDestinationNode.h

@@ -56,6 +56,11 @@ public:

virtual void startRendering() = 0;

virtual void stopRendering() = 0;

+ // TODO: Refactoring needed. This method is only used by OfflineAudioContext.

+ virtual size_t quantizeTimeToRenderQuantum(double) const { return 0; }

+ virtual WebThread* offlineRenderThread();

protected:

// LocalAudioInputProvider allows us to expose an AudioSourceProvider for local/live audio input.

// If there is local/live audio input, we call set() with the audio input data every render quantum.