Source/modules/webaudio/OfflineAudioContext.idl - Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OfflineAudioContext.idl

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Initial review + layout tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webaudio/OfflineAudioContext.cpp ('K') | « Source/modules/webaudio/OfflineAudioContext.cpp ('k') | Source/modules/webaudio/OfflineAudioDestinationNode.h » ('j') | Source/modules/webaudio/OfflineAudioDestinationNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/OfflineAudioContext.idl

diff --git a/Source/modules/webaudio/OfflineAudioContext.idl b/Source/modules/webaudio/OfflineAudioContext.idl

index 4c225d938f979818b2ae117fab4f2cf87b37c8e7..a5d50deddedbedee48806a8f28c477e118be5252 100644

--- a/Source/modules/webaudio/OfflineAudioContext.idl

+++ b/Source/modules/webaudio/OfflineAudioContext.idl

@@ -32,4 +32,6 @@

// Offline rendering

attribute EventHandler oncomplete;

[CallWith=ScriptState,ImplementedAs=startOfflineRendering] Promise<AudioBuffer> startRendering();

+ [CallWith=ScriptState,ImplementedAs=suspendOfflineRendering] Promise<void> suspend(double suspendTime);

Raymond Toy 2015/05/28 16:37:36 Do we want to add a use counter for offline suspen

hongchan 2015/06/09 20:50:00 Should it be a separate CL?

+ [CallWith=ScriptState,ImplementedAs=resumeOfflineRendering] Promise<void> resume();

};