Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: LayoutTests/webaudio/audiocontext-suspend-resume.html

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Initial review + layout tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/webaudio/audiocontext-suspend-resume.html
diff --git a/LayoutTests/webaudio/audiocontext-suspend-resume.html b/LayoutTests/webaudio/audiocontext-suspend-resume.html
index 99190ab92e38345c24e308359be7e9f3b2564470..f24056d6c45eb6d20e084bd7ddaa4ab5045cfa35 100644
--- a/LayoutTests/webaudio/audiocontext-suspend-resume.html
+++ b/LayoutTests/webaudio/audiocontext-suspend-resume.html
@@ -57,12 +57,12 @@
p1.then(
handlePromise(testFailed, "offlineContext.suspend() should have been rejected for an offline context"),
function (e) {
- if (e.name === "InvalidAccessError") {
+ if (e.name === "TypeError") {
testPassed(
"offlineContext.suspend() was correctly rejected: " + e);
} else {
testFailed(
- "offlineContext.suspend() was correctly rejected but expected InvalidAccessError, not: " + e);
+ "offlineContext.suspend() was correctly rejected but expected TypeError, not: " + e);
}
}
).then(done);
@@ -83,12 +83,12 @@
p2.then(
handlePromise(testFailed, "offlineContext.resume() should have been rejected for an offline context"),
function (e) {
- if (e.name === "InvalidAccessError") {
+ if (e.name === "InvalidStateError") {
testPassed(
"offlineContext.resume() was correctly rejected: " + e);
} else {
testFailed(
- "offlineContext.resume() was correctly rejected but expected InvalidAccessError, not: " + e);
+ "offlineContext.resume() was correctly rejected but expected InvalidStateError, not: " + e);
}
}
).then(done);
@@ -107,13 +107,13 @@
shouldBeEqualToString("offlineContext.state", "closed");
// suspend() should be rejected on a closed context.
- offlineContext.suspend().then(
+ offlineContext.suspend(1.0).then(
Raymond Toy 2015/05/28 16:37:34 Why 1.0 and not durationInSeconds? This seems to
handlePromise(testFailed, "offlineContext.suspend() on a closed context not rejected"),
function (e) {
- if (e.name === "InvalidAccessError") {
+ if (e.name === "InvalidStateError") {
testPassed("offlineContext.suspend() on a closed context rejected: " + e);
} else {
- testFailed("offlineContext.suspend() on a closed context rejected but expected InvalidAccessError, not: " + e);
+ testFailed("offlineContext.suspend() on a closed context rejected but expected InvalidStateError, not: " + e);
}
}
).then(function () {
@@ -121,10 +121,10 @@
offlineContext.resume().then(
handlePromise(testFailed, "offlineContext.resume() on a closed context not rejected"),
function (e) {
- if (e.name === "InvalidAccessError") {
+ if (e.name === "InvalidStateError") {
testPassed("offlineContext.resume() on a closed context rejected: " + e);
} else {
- testFailed("offlineContext.resume() on a closed context rejected but expected InvalidAccessError, not: " + e);
+ testFailed("offlineContext.resume() on a closed context rejected but expected InvalidStateError, not: " + e);
}
}
).then(done);

Powered by Google App Engine
This is Rietveld 408576698