LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt - Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext

Side by Side Diff: LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adapting CL to AbstractAudioContext Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html ('K') | « LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html ('k') | LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html » ('j') | LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Basic test for OfflineAudioContext.suspend() and OfflineAudioContext.resume().

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6 PASS context.suspend() rejected correctly (with TypeError: Failed to execute 'su spend' on 'OfflineAudioContext': 1 argument required, but only 0 present.).

	7 PASS context.suspend(-1.0) rejected correctly (with InvalidStateError: negative suspend time (-1) is not allowed).

	8 PASS Scheduling a suspend in the past rejected correctly (with InvalidStateError : cannot schedule a suspend at frame 17536 (0.399229 seconds) because it is earl ier than the current frame of 22016).
	Raymond Toy 2015/07/15 20:59:13 Might be nice to have the current frame also inclu Might be nice to have the current frame also include the time, like you did for the suspend time. I was initialized confused by the suspend time of 0.399229 sec because I was expecting something much closer to 0.4 sec, because the suspend time was 0.5 sec (which gets quantized to 22016/44100 sec). hongchan 2015/07/15 23:24:22 The frame 17536 is a quantized frame number, but 0 Show quoted text On 2015/07/15 20:59:13, Raymond Toy wrote: > Might be nice to have the current frame also include the time, like you did for > the suspend time. I was initialized confused by the suspend time of 0.399229 > sec because I was expecting something much closer to 0.4 sec, because the > suspend time was 0.5 sec (which gets quantized to 22016/44100 sec). The frame 17536 is a quantized frame number, but 0.399229 second is the non-quantized/original suspension time. It is because the current time after the suspension is not exact 0.5; it is 0.4992290249433107. (= 128/44100 * (344/2)) so taking 0.1 from it would be ~0.399229. Raymond Toy 2015/07/16 16:24:23 Yes, that's why I think it might be nice to print Show quoted text On 2015/07/15 23:24:22, hoch wrote: > On 2015/07/15 20:59:13, Raymond Toy wrote: > > Might be nice to have the current frame also include the time, like you did > for > > the suspend time. I was initialized confused by the suspend time of 0.399229 > > sec because I was expecting something much closer to 0.4 sec, because the > > suspend time was 0.5 sec (which gets quantized to 22016/44100 sec). > > The frame 17536 is a quantized frame number, but 0.399229 second is the > non-quantized/original suspension time. > > It is because the current time after the suspension is not exact 0.5; it is > 0.4992290249433107. (= 128/44100 * (344/2)) so taking 0.1 from it would be > ~0.399229. Yes, that's why I think it might be nice to print out the time for the current frame (22016) which would make it obvious why .399229 happens.
	9 PASS Calling multiple suspends at the same rendering quantum rejected correctly (with InvalidStateError: cannot schedule more than one suspend at frame 128 (0.0 0435374 seconds)).

	10 PASS Resuming before suspend rejected correctly (with InvalidStateError: cannot resume a context that is not suspended).

	11 PASS Calling resume on non-suspended context rejected correctly (with InvalidSta teError: cannot resume a context that has not started).

	12 PASS successfullyParsed is true

	13

	14 TEST COMPLETE

	15

OLD	NEW