LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html - Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext

Side by Side Diff: LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html

Issue 1140723003: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Initial review + layout tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html ('K') | « LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt ('k') | LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt » ('j') | LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 <script src="resources/compatibility.js"></script>

	6 <script src="resources/audio-testing.js"></script>

	7 </head>

	8

	9 <body>

	10 <script>

	11 description('Test event handler callback from OfflineAudioContext resume/s uspend.');

	12 window.jsTestIsAsync = true;

	13

	14 var context;

	15 var sampleRate = 44100;

	16 var renderDuration = 2;

	17 var renderQuantum = 128;

	18 var scheduledSuspendTime = 0.1;
	Raymond Toy 2015/05/28 16:37:34 I think you should compute scheduledSuspendTime fr I think you should compute scheduledSuspendTime from the sample rate and render quantum so that it definitely does not fall on a render boundary. (In case some one changes sampleRate to a different value.) hongchan 2015/06/09 20:49:58 It should not matter, I believe. It should do what Show quoted text On 2015/05/28 16:37:34, Raymond Toy wrote: > I think you should compute scheduledSuspendTime from the sample rate and render > quantum so that it definitely does not fall on a render boundary. (In case some > one changes sampleRate to a different value.) It should not matter, I believe. It should do what it is supposed to do whether the suspend time falls into the boundary or somewhere else.
	19

	20 // Get the time quantized by render quantum size.

	21 function quantizeByRenderQuantum(time) {

	22 var samples = time * sampleRate;

	23 return (samples - (samples % renderQuantum)) / sampleRate;

	24 }

	25

	26 function runTest() {

	27 context = new OfflineAudioContext(1, sampleRate * renderDuration, sample Rate);

	28

	29 context.onstatechange = function () {

	30 if (context.state === 'suspended') {

	31 Should('context.currentTime', context.currentTime)

	32 .beEqualTo(quantizeByRenderQuantum(scheduledSuspendTime));

	33

	34 // When context.currentTime 0.1 > renderDuration, the promise should
	Raymond Toy 2015/05/28 16:37:34 "currentTime 0.1"? "currentTime 0.1"? hongchan 2015/06/09 20:49:58 Oops. This should read \|context.currentTime + 0.1 Show quoted text On 2015/05/28 16:37:34, Raymond Toy wrote: > "currentTime 0.1"? Oops. This should read \|context.currentTime + 0.1 > renderDuration\|. Will fix it.
	35 // be rejected and throw an exception.

	36 scheduledSuspendTime = context.currentTime + 0.1;
	Raymond Toy 2015/05/28 16:37:34 This delta of 0.1 should also be computed so that This delta of 0.1 should also be computed so that it does (or does not) cause the suspend time to be on a rendering boundary. Or perhaps it doesn't matter? hongchan 2015/06/09 20:49:58 I don't think it matters as the comment above. Show quoted text On 2015/05/28 16:37:34, Raymond Toy wrote: > This delta of 0.1 should also be computed so that it does (or does not) cause > the suspend time to be on a rendering boundary. Or perhaps it doesn't matter? I don't think it matters as the comment above.
	37 context.suspend(scheduledSuspendTime);

	38 context.resume();

	39 }

	40 };

	41

	42 context.oncomplete = function () {

	43 Should('context.state', context.state).beEqualTo('closed');

	44 finishJSTest();

	45 };

	46

	47 context.suspend(scheduledSuspendTime);

	48 context.startRendering();
	Raymond Toy 2015/05/28 16:37:34 If you really want to use oncomplete instead of a If you really want to use oncomplete instead of a promise for offline context, say why. hongchan 2015/06/09 20:49:58 This test is about testing all event handlers are Show quoted text On 2015/05/28 16:37:34, Raymond Toy wrote: > If you really want to use oncomplete instead of a promise for offline context, > say why. This test is about testing all event handlers are working properly. The CL changed the code position for oncomplete event handler and I just wanted to show that everything works as intended.
	49 }

	50

	51 runTest();

	52 successfullyParsed = true;

	53 </script>

	54

	55 </body>

	56 </html>

OLD	NEW