[PresentationAPI] Implements send API for Blob data from WebPresentationClient

content/renderer/presentation/presentation_dispatcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/presentation/presentation_dispatcher.h"
 
 #include "base/logging.h"
 #include "content/common/presentation/presentation_service.mojom.h"
 #include "content/public/common/presentation_constants.h"
 #include "content/public/common/service_registry.h"
@@ skipping 36 matching lines @@
   return blink::WebPresentationSessionState::Disconnected;
 }
 
 GURL GetPresentationURLFromFrame(content::RenderFrame* frame) {
   DCHECK(frame);
 
   GURL url(frame->GetWebFrame()->document().defaultPresentationURL());
   return url.is_valid() ? url : GURL();
 }
 
+presentation::SessionMessage* GetMojoSessionMessage(
+    const blink::WebString& presentationUrl,
+    const blink::WebString& presentationId,
+    const uint8* data,
+    size_t length) {
+  presentation::SessionMessage* session_message =
+      new presentation::SessionMessage();
+  session_message->presentation_url = presentationUrl.utf8();
+  session_message->presentation_id = presentationId.utf8();
+  const std::vector<uint8> vector(data, data + length);
+  session_message->data = mojo::Array<uint8>::From(vector);
+  // Fill session_message->type in the caller.

[mark a. foltz, 2015/06/02 23:51:02]

Why not pass the type as an argument and fill it in here?

[USE s.singapati at gmail.com, 2015/06/03 15:03:50]

Done. Well, Yes.

+  return session_message;
+}
+
 }  // namespace
 
 namespace content {
 
 PresentationDispatcher::PresentationDispatcher(RenderFrame* render_frame)
     : RenderFrameObserver(render_frame),
       controller_(nullptr),
       binding_(this) {
 }
 
@@ skipping 91 matching lines @@
     const blink::WebString& presentationId,
     const uint8* data,
     size_t length) {
   DCHECK(data);
   if (length > kMaxPresentationSessionMessageSize) {
     // TODO(crbug.com/459008): Same as in sendString().
     LOG(WARNING) << "data size exceeded limit!";
     return;
   }
 
-  const std::vector<uint8> vector(data, data + length);
   presentation::SessionMessage* session_message =
-      new presentation::SessionMessage();
-  session_message->presentation_url = presentationUrl.utf8();
-  session_message->presentation_id = presentationId.utf8();
+      GetMojoSessionMessage(presentationUrl, presentationId, data, length);
   session_message->type = presentation::PresentationMessageType::
                           PRESENTATION_MESSAGE_TYPE_ARRAY_BUFFER;
-  session_message->data = mojo::Array<uint8>::From(vector);
-
   message_request_queue_.push(make_linked_ptr(session_message));
   // Start processing request if only one in the queue.
   if (message_request_queue_.size() == 1) {
     const linked_ptr<presentation::SessionMessage>& request =
         message_request_queue_.front();
     DoSendMessage(*request);
   }
 }
 
+void PresentationDispatcher::sendBlobData(
+    const blink::WebString& presentationUrl,
+    const blink::WebString& presentationId,
+    const uint8* data,
+    size_t length) {
+  DCHECK(data);
+  if (length > kMaxPresentationSessionMessageSize) {
+    // TODO(crbug.com/459008): Same as in sendString().
+    LOG(WARNING) << "data size exceeded limit!";
+    return;
+  }
+
+  presentation::SessionMessage* session_message =
+      GetMojoSessionMessage(presentationUrl, presentationId, data, length);
+  session_message->type = presentation::PresentationMessageType::
+                          PRESENTATION_MESSAGE_TYPE_BLOB;
+  message_request_queue_.push(make_linked_ptr(session_message));
+  if (message_request_queue_.size() == 1) {
+    const linked_ptr<presentation::SessionMessage>& request =
+        message_request_queue_.front();
+    DoSendMessage(*request);
+  }
+}
+
 void PresentationDispatcher::DoSendMessage(
     const presentation::SessionMessage& session_message) {
   ConnectToPresentationServiceIfNeeded();
 
   presentation::SessionMessagePtr message_request(
       presentation::SessionMessage::New());
   message_request->presentation_url = session_message.presentation_url;
   message_request->presentation_id = session_message.presentation_id;
   message_request->type = session_message.type;
   if (session_message.type == presentation::PresentationMessageType::
                               PRESENTATION_MESSAGE_TYPE_TEXT) {
     message_request->message = session_message.message;
-  } else if (session_message.type == presentation::PresentationMessageType::
-                                      PRESENTATION_MESSAGE_TYPE_ARRAY_BUFFER) {
+  } else {
+    // ArrayBuffer or Blob types.

[mark a. foltz, 2015/06/02 23:51:02]

Prefer seeing a switch { } statement here with a default NOTREACHED() so we
don't assume that new types are binary.

[USE s.singapati at gmail.com, 2015/06/03 15:03:50]

Done.

     message_request->data = mojo::Array<uint8>::From(
         session_message.data.storage());
   }
 
   presentation_service_->SendSessionMessage(
       message_request.Pass(),
       base::Bind(&PresentationDispatcher::HandleSendMessageRequests,
                  base::Unretained(this)));
 }
 
@@ skipping 147 matching lines @@
   presentation_service_->ListenForSessionStateChange(base::Bind(
       &PresentationDispatcher::OnSessionStateChange,
       base::Unretained(this)));
   presentation_service_->ListenForSessionMessages(
       base::Bind(&PresentationDispatcher::OnSessionMessagesReceived,
       base::Unretained(this)));
   */
 }
 
 }  // namespace content