Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1140713004: Update "manage saved passwords" text in Chrome settings page on Android. (Closed)

Created:
5 years, 7 months ago by engedy
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update "manage saved passwords" text in Chrome settings page on Android. R=vabr@chromium.org,newt@chromium.org BUG=486739 Committed: https://crrev.com/ca534a4a6550e9f70df2debbb6e3e39a11e8d751 Cr-Commit-Position: refs/heads/master@{#330228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
engedy
@Vaclav, could you please verify the string? @Newton, could you please review as ONWER?
5 years, 7 months ago (2015-05-15 22:11:33 UTC) #2
engedy
The "product name" here coincides with the host part of the product availability URL. Still, ...
5 years, 7 months ago (2015-05-15 22:20:28 UTC) #3
vabr (Chromium)
String matches the specs. LGTM. Cheers, Vaclav
5 years, 7 months ago (2015-05-15 22:24:24 UTC) #4
newt (away)
lgtm
5 years, 7 months ago (2015-05-15 22:28:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140713004/1
5 years, 7 months ago (2015-05-15 22:37:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 23:24:48 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca534a4a6550e9f70df2debbb6e3e39a11e8d751
Cr-Commit-Position: refs/heads/master@{#330228}

Powered by Google App Engine
This is Rietveld 408576698