pkg/dart2js_incremental/lib/caching_compiler.dart - Issue 1140703006: dart2js: Construct the entire output as a single AST before printing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 1140703006: dart2js: Construct the entire output as a single AST before printing. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/dart2js_incremental/lib/caching_compiler.dart

diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart

index 7c7d34198907c8baa2915daef46d66af9ec9029c..06445cbec20031b7b6010c6e9e58fd29e980f59e 100644

--- a/pkg/dart2js_incremental/lib/caching_compiler.dart

+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart

@@ -130,7 +130,6 @@ Future<Compiler> reuseCompiler(

backend.emitter.oldEmitter

..outputBuffers.clear()

- ..isolateProperties = null

..classesCollector = null

..mangledFieldNames.clear()

..mangledGlobalFieldNames.clear()

« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/js_ast/lib/src/builder.dart » ('j') | no next file with comments »