Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1140693004: [Android] Prevent touch interception for browser-consumed touches (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Prevent touch interception for browser-consumed touches Browser-based widgets that overlay content have a shot at consuming touch events, e.g., selection handles. Such touches are reported as consumed to the View chain, however, embedding apps still have the opportunity to intercept those touch sequences. This can lead to double-handling, e.g., when dragging a selection handle left or right and triggering a View side swipe. Prevent this by calling requestDisallowInterceptTouchEvent() for touches that are consumed by such browser-based widgets. Note that we cannot call this method for all touch events as touch dispatch is often asynchronous and the disposition of the touch handling result cannot be immediately known when the touch is received from the Android platform. BUG=489337 Committed: https://crrev.com/39083255b50c17e8a75705d4bd6f0a209f9ccdbd Cr-Commit-Position: refs/heads/master@{#330426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 4 chunks +30 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
tedchoc: PTAL, thanks. The RWHVAndroid::ResetGestureDetection changes were taken from (the already approved but not yet ...
5 years, 7 months ago (2015-05-18 18:33:44 UTC) #2
Ted C
lgtm
5 years, 7 months ago (2015-05-18 20:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140693004/1
5 years, 7 months ago (2015-05-18 21:04:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 21:22:54 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:43:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39083255b50c17e8a75705d4bd6f0a209f9ccdbd
Cr-Commit-Position: refs/heads/master@{#330426}

Powered by Google App Engine
This is Rietveld 408576698