gpu/command_buffer/service/stream_texture_manager_in_process_android.cc - Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GetInternalFormat override to MockGLImage. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc ('k') | gpu/command_buffer/service/texture_definition.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

diff --git a/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc b/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

index 174edaa6ee9915391fe87dd12bc64a8b69fcdf65..0e9dd14d8a50791ab6f4a486a37be71ae122d4b3 100644

--- a/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

+++ b/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

@@ -25,6 +25,7 @@ class GLImageImpl : public gfx::GLImage {

// implement gfx::GLImage

void Destroy(bool have_context) override;

gfx::Size GetSize() override;

+ unsigned GetInternalFormat() override;

bool BindTexImage(unsigned target) override;

void ReleaseTexImage(unsigned target) override;

bool CopyTexImage(unsigned target) override;

@@ -64,6 +65,10 @@ gfx::Size GLImageImpl::GetSize() {

return gfx::Size();

}

+unsigned GLImageImpl::GetInternalFormat() {

+ return GL_RGBA;

bool GLImageImpl::BindTexImage(unsigned target) {

NOTREACHED();

return false;