gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/stream_texture_android.cc ('k') | gpu/command_buffer/service/stream_texture_manager_in_process_android.cc » ('j') | ui/gl/gl_image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index a22c2f9b83e6f863d1d0e213dba7c857b685e56f..98f450f28928262378d216198c39ce92db6da677 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -12459,8 +12459,9 @@ void GLES2DecoderImpl::DoBindTexImage2DCHROMIUM(

gfx::Size size = gl_image->GetSize();

texture_manager()->SetLevelInfo(

- texture_ref, target, 0, GL_RGBA, size.width(), size.height(), 1, 0,

- GL_RGBA, GL_UNSIGNED_BYTE, true);

+ texture_ref, target, 0, gl_image->GetFormat(),

+ size.width(), size.height(), 1, 0,

+ gl_image->GetFormat(), GL_UNSIGNED_BYTE, true);

texture_manager()->SetLevelImage(texture_ref, target, 0, gl_image);

}

@@ -12498,8 +12499,8 @@ void GLES2DecoderImpl::DoReleaseTexImage2DCHROMIUM(

}

texture_manager()->SetLevelInfo(

- texture_ref, target, 0, GL_RGBA, 0, 0, 1, 0,

- GL_RGBA, GL_UNSIGNED_BYTE, false);

+ texture_ref, target, 0, gl_image->GetFormat(), 0, 0, 1, 0,

+ gl_image->GetFormat(), GL_UNSIGNED_BYTE, false);

}

error::Error GLES2DecoderImpl::HandleTraceBeginCHROMIUM(