[sync] Add WalletMetadataSpecifics protobuf.

[sync] Add WalletMetadataSpecifics protobuf.

BUG=481595
Committed: https://crrev.com/ec11d7719a7896806b013b58c515864441dc296f
Cr-Commit-Position: refs/heads/master@{#330945}

[please use gerrit instead, 2015-05-18 23:28:51]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2015-05-18 23:32:19]

rouslan@chromium.org changed reviewers:
+ zea@chromium.org

[please use gerrit instead, 2015-05-18 23:32:20]

Nicolas, PTAL.

This is a part of https://crrev.com/1110833002, which might be difficult to
review all at once due to its size.

[Nicolas Zea, 2015-05-20 21:41:46]

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
File sync/protocol/autofill_specifics.proto (right):

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
sync/protocol/autofill_specifics.proto:186: // Unique ID string of the
corresponding Wallet data.
nit: Information about how it's generated?

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
sync/protocol/autofill_specifics.proto:193: optional int64 use_date = 4;
nit: What are the units for this? Milliseconds since windows epoch?

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:136: optional WalletMetadataSpecifics wallet_metadata =
108302;
nit: not strictly required, but it would be good to choose a revision higher
than the others, as it helps to give us an idea of the order in which a datatype
was added, and how old it is.

[please use gerrit instead, 2015-05-20 23:37:39]

Nicolas, PTAL Patch Set 2.

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
File sync/protocol/autofill_specifics.proto (right):

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
sync/protocol/autofill_specifics.proto:186: // Unique ID string of the
corresponding Wallet data.
On 2015/05/20 21:41:45, Nicolas Zea wrote:
> nit: Information about how it's generated?

Done.

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
sync/protocol/autofill_specifics.proto:193: optional int64 use_date = 4;
On 2015/05/20 21:41:45, Nicolas Zea wrote:
> nit: What are the units for this? Milliseconds since windows epoch?

Done.

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:136: optional WalletMetadataSpecifics wallet_metadata =
108302;
On 2015/05/20 21:41:45, Nicolas Zea wrote:
> nit: not strictly required, but it would be good to choose a revision higher
> than the others, as it helps to give us an idea of the order in which a
datatype
> was added, and how old it is.

Used a Cr-Commit-Position, since chromium revisions are now git hash tags, which
are unusable here. Updated the comment above, too.

[please use gerrit instead, 2015-05-20 23:39:12]

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
File sync/protocol/autofill_specifics.proto (right):

https://codereview.chromium.org/1140653006/diff/20001/sync/protocol/autofill_...
sync/protocol/autofill_specifics.proto:193: optional int64 use_date = 4;
On 2015/05/20 23:37:39, Rouslan wrote:
> On 2015/05/20 21:41:45, Nicolas Zea wrote:
> > nit: What are the units for this? Milliseconds since windows epoch?
> 
> Done.

As documented here:
https://code.google.com/p/chromium/codesearch#chromium/src/base/time/time_pos...

[Nicolas Zea, 2015-05-21 15:17:09]

LGTM

[please use gerrit instead, 2015-05-21 17:15:30]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-05-21 17:16:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140653006/40001

[commit-bot: I haz the power, 2015-05-21 17:22:06]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-21 17:23:04]

Patchset 2 (id:??) landed as
https://crrev.com/ec11d7719a7896806b013b58c515864441dc296f
Cr-Commit-Position: refs/heads/master@{#330945}