Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140643004: Add _aa variants of Xfermode benches. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add _aa variants of Xfermode benches. Also, allow multiple DEF_BENCH() per line by using __COUNTER__ instead of __LINE__. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d0a1088bf747a9291a178cb08e162d2c84a9aa7c

Patch Set 1 #

Patch Set 2 : Text for AA #

Patch Set 3 : msvc #

Patch Set 4 : go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M bench/Benchmark.h View 1 chunk +4 lines, -5 lines 0 comments Download
M bench/XfermodeBench.cpp View 1 2 2 chunks +35 lines, -24 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
mtklein_C
5 years, 7 months ago (2015-05-13 14:16:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140643004/1
5 years, 7 months ago (2015-05-13 14:16:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 14:55:47 UTC) #6
reed1
might also try a diff primitive (other than rect) : wacky path or stroked circle ...
5 years, 7 months ago (2015-05-13 15:34:43 UTC) #7
mtklein
Righto. AA -> text, non-AA -> rects now.
5 years, 7 months ago (2015-05-13 15:52:23 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140643004/20001
5 years, 7 months ago (2015-05-13 15:52:43 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1025)
5 years, 7 months ago (2015-05-13 15:59:01 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140643004/60001
5 years, 7 months ago (2015-05-13 16:03:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 16:10:48 UTC) #17
mtklein
lgtm
5 years, 7 months ago (2015-05-13 18:47:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140643004/60001
5 years, 7 months ago (2015-05-13 18:53:40 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:54:07 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d0a1088bf747a9291a178cb08e162d2c84a9aa7c

Powered by Google App Engine
This is Rietveld 408576698