Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1140643002: Fix device_event_log component build, make NonThreadSafe (Take 2) (Closed)

Created:
5 years, 7 months ago by stevenjb
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix device_event_log component build, make NonThreadSafe (Take 2) This patch includes the correct GN changes. This CL does the following: * Fixes the component build * Limits the length of LogEntry strings * Cleans up the code a little to help with crash debugging BUG=479095 For device_event_log gypi: TBR=reillyg@chromium.org Committed: https://crrev.com/6a00a6f0a46ce2852dc526dfc2ea056a8115ef8c Cr-Commit-Position: refs/heads/master@{#329320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -66 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/device_event_log.gypi View 2 chunks +4 lines, -1 line 0 comments Download
M components/device_event_log/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M components/device_event_log/device_event_log.h View 5 chunks +31 lines, -23 lines 0 comments Download
M components/device_event_log/device_event_log.cc View 2 chunks +7 lines, -1 line 0 comments Download
A components/device_event_log/device_event_log_export.h View 1 chunk +34 lines, -0 lines 0 comments Download
M components/device_event_log/device_event_log_impl.h View 3 chunks +11 lines, -2 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 4 chunks +47 lines, -24 lines 0 comments Download
M components/device_event_log/device_event_log_impl_unittest.cc View 7 chunks +47 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140643002/1
5 years, 7 months ago (2015-05-12 01:13:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 02:14:19 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:15:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a00a6f0a46ce2852dc526dfc2ea056a8115ef8c
Cr-Commit-Position: refs/heads/master@{#329320}

Powered by Google App Engine
This is Rietveld 408576698