Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1140633005: Android: Fix ChildThreadImpl::ShutdownThread() (Closed)

Created:
5 years, 7 months ago by no sievers
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix ChildThreadImpl::ShutdownThread() Make this work independent for MsgLoop vs. ChildThread destruction order and simplify the code a bit. BUG=465397 Committed: https://crrev.com/d294ee3e94047801a1d3bdf662b4176b64c69207 Cr-Commit-Position: refs/heads/master@{#330655}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -55 lines) Patch
M content/child/child_thread_impl.cc View 1 2 3 5 chunks +49 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
no sievers
ptal
5 years, 7 months ago (2015-05-19 21:33:43 UTC) #2
piman
lgtm https://codereview.chromium.org/1140633005/diff/40001/content/child/child_thread_impl.cc File content/child/child_thread_impl.cc (right): https://codereview.chromium.org/1140633005/diff/40001/content/child/child_thread_impl.cc#newcode210 content/child/child_thread_impl.cc:210: cond_var_.Signal(); nit: You can signal while the lock ...
5 years, 7 months ago (2015-05-19 22:36:29 UTC) #5
no sievers
https://codereview.chromium.org/1140633005/diff/40001/content/child/child_thread_impl.cc File content/child/child_thread_impl.cc (right): https://codereview.chromium.org/1140633005/diff/40001/content/child/child_thread_impl.cc#newcode210 content/child/child_thread_impl.cc:210: cond_var_.Signal(); On 2015/05/19 22:36:29, piman (Very slow to review) ...
5 years, 7 months ago (2015-05-19 22:41:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140633005/60001
5 years, 7 months ago (2015-05-19 22:43:44 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 00:27:48 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:28:54 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d294ee3e94047801a1d3bdf662b4176b64c69207
Cr-Commit-Position: refs/heads/master@{#330655}

Powered by Google App Engine
This is Rietveld 408576698