Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1140603002: Roll PDFium to 2daf76f (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to 2daf76f The most significant change is to expose its public/ directory. This requires simultaneous path changes in src/pdf. This pulls in: 2daf76f Add owners file for PDFium ac19d2d Create top-level public/ header directory. 0627231 Move function prototypes to new doc_utils.h file 6661fd4 Fix compilation under chromium checkouts. 17ea732 Better error from pdfium_test when page too big to render. 470408c Fix errors from commit f0a169e. f0a169e Fix a bunch of -Wunused-but-set-variable warnings. 21031ad Support arrays in nonstd::unique_ptr<>. 1fd0b10 Manual revert of ad2a822ce5c3 9ea57a4 Remove FX_STRSIZE casts, use safe conversions BUG=pdfium:154 Committed: https://crrev.com/35024356bfff4fd374e69b733b77f38271a6107d Cr-Commit-Position: refs/heads/master@{#329304}

Patch Set 1 #

Patch Set 2 : Re-upload (500s) #

Patch Set 3 : Pull new OWNERS via DEPS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdf/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M pdf/pdfium/pdfium_assert_matching_enums.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +4 lines, -4 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M pdf/pdfium/pdfium_mem_buffer_file_read.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_mem_buffer_file_write.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_page.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Tom Sepez
Lei, for review.
5 years, 7 months ago (2015-05-11 22:11:10 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-11 22:22:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140603002/20001
5 years, 7 months ago (2015-05-11 23:08:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62816)
5 years, 7 months ago (2015-05-11 23:16:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140603002/20001
5 years, 7 months ago (2015-05-11 23:38:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62825)
5 years, 7 months ago (2015-05-11 23:51:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140603002/40001
5 years, 7 months ago (2015-05-11 23:57:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 01:08:59 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 01:09:44 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/35024356bfff4fd374e69b733b77f38271a6107d
Cr-Commit-Position: refs/heads/master@{#329304}

Powered by Google App Engine
This is Rietveld 408576698