Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11406: Simplify virtual frame by removing the virtual stack pointer, which... (Closed)

Created:
12 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva, William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Simplify virtual frame by removing the virtual stack pointer, which can be derived from the backing store's length. Committed: http://code.google.com/p/v8/source/detail?r=780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -60 lines) Patch
M src/virtual-frame-arm.h View 3 chunks +3 lines, -16 lines 0 comments Download
M src/virtual-frame-arm.cc View 5 chunks +11 lines, -14 lines 2 comments Download
M src/virtual-frame-ia32.h View 3 chunks +3 lines, -16 lines 0 comments Download
M src/virtual-frame-ia32.cc View 5 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
12 years, 1 month ago (2008-11-17 16:04:51 UTC) #1
iposva
12 years, 1 month ago (2008-11-17 17:11:53 UTC) #2
Comments from left field.

-Ivan

PS. Otherwise LGTM and thanks for the cleanup.

http://codereview.chromium.org/11406/diff/1/4
File src/virtual-frame-arm.cc (right):

http://codereview.chromium.org/11406/diff/1/4#newcode46
Line 46: frame_pointer_(-1) {
Ideally you could define an illegal index and use that wherever the VirtualFrame
has not yet been setup and in other similar situations.

http://codereview.chromium.org/11406/diff/1/4#newcode111
Line 111: Adjust(4);
Can you please document the magic numbers in this file? I assume 4 is the size
of the arm native stack frame. A simple comment referring to the line below
would do.

Powered by Google App Engine
This is Rietveld 408576698