third_party/closure_compiler/compile.py - Issue 1140593003: Remove ExtraAnnotationNames override in Runner.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile.py

Issue 1140593003: Remove ExtraAnnotationNames override in Runner.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java » ('j') | third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/compile.py

diff --git a/third_party/closure_compiler/compile.py b/third_party/closure_compiler/compile.py

index 091a8470e3da888fb6a69cfda341c9422e9ea65d..204ed918251e736fe437132bd87b7f161dd5c644 100755

--- a/third_party/closure_compiler/compile.py

+++ b/third_party/closure_compiler/compile.py

@@ -47,14 +47,15 @@ class Checker(object):

"visibility",

]

- # Extra @jsDocAnnotations used when compiling polymer code.

- _POLYMER_EXTRA_ANNOTATIONS = [

+ # Extra @jsDocAnnotations used when compiling Chrome JS.

+ _EXTRA_ANNOTATIONS = [

Dan Beam 2015/05/12 23:09:20 nit: _EXTRA_JSDOC_ANNOTATIONS, remove comment

Jeremy Klein 2015/05/12 23:39:24 Reverting this file's changes.

"attribute",

"status",

"element",

"homepage",

"submodule",

"group",

+ "suppressReceiverCheck",

Tyler Breisacher (Chromium) 2015/05/12 21:39:51 This seems to come from the devtools code. I reall

Jeremy Klein 2015/05/12 23:39:24 Done.

]

_COMMON_CLOSURE_ARGS = [

@@ -67,7 +68,7 @@ class Checker(object):

] + [

"--jscomp_error=%s" % err for err in _COMMON_JSCOMP_ERRORS

] + [

- "--extra_annotation_name=%s" % a for a in _POLYMER_EXTRA_ANNOTATIONS

+ "--extra_annotation_name=%s" % a for a in _EXTRA_ANNOTATIONS

]

# These are the extra flags used when compiling in strict mode.