Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1140583005: Show remaing space of MTP device in File Manager. (Closed)

Created:
5 years, 7 months ago by yawano
Modified:
5 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show remaing space of MTP device in File Manager. This CL shows remaing space at the mount time in file manager. A CL to make file manager show latest remaing space will come as another CL. BUG=486396 Committed: https://crrev.com/78cbe4a3e3221f0e33ad72db8be8b5ede8834892 Cr-Commit-Position: refs/heads/master@{#330674}

Patch Set 1 #

Patch Set 2 : Fix failed test case. #

Total comments: 2

Patch Set 3 : Return false when MtpStorageInfo is not found. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 2 4 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
yawano
PTAL. Thank you!
5 years, 7 months ago (2015-05-19 03:38:21 UTC) #2
kinaba
lgtm
5 years, 7 months ago (2015-05-19 06:01:20 UTC) #3
yawano
On 2015/05/19 06:01:20, kinaba wrote: > lgtm Thank you!
5 years, 7 months ago (2015-05-19 06:02:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140583005/1
5 years, 7 months ago (2015-05-19 06:02:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/58829)
5 years, 7 months ago (2015-05-19 07:10:35 UTC) #8
yawano
The previous patch set has broken a test case. Fixed with new patch set. PTAL. ...
5 years, 7 months ago (2015-05-19 09:00:23 UTC) #9
kinaba
https://codereview.chromium.org/1140583005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/1140583005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode442 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:442: } I guess it's safer to return false when ...
5 years, 7 months ago (2015-05-19 09:37:31 UTC) #10
yawano
Thank you for the review! PTAL. https://codereview.chromium.org/1140583005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/1140583005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode442 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:442: } On 2015/05/19 ...
5 years, 7 months ago (2015-05-19 12:08:13 UTC) #11
kinaba
lgtm
5 years, 7 months ago (2015-05-19 12:15:40 UTC) #12
yawano
On 2015/05/19 12:15:40, kinaba wrote: > lgtm Thank you!
5 years, 7 months ago (2015-05-20 01:52:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140583005/40001
5 years, 7 months ago (2015-05-20 01:54:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 01:59:49 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 02:03:08 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78cbe4a3e3221f0e33ad72db8be8b5ede8834892
Cr-Commit-Position: refs/heads/master@{#330674}

Powered by Google App Engine
This is Rietveld 408576698