Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1140583004: [turbofan] Add frame state before JavaScript comparisons. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add frame state before JavaScript comparisons. Use these check points to optimize comparisons where we already know that one side cannot be a String (or turn into a string via ToPrimitive). Also remove bunch of useless DoNotCrash tests for the scheduler that are painful to maintain and add almost no value. R=jarin@chromium.org Committed: https://crrev.com/2111d18dbad8ce14124d69488aa3568dd4604768 Cr-Commit-Position: refs/heads/master@{#28383}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also simplify ConvertPrimitiveToNumber in JSTypedLowering. #

Patch Set 3 : Remove obsolete #if 0. Slightly refactor strong mode check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1384 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 7 chunks +22 lines, -41 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +10 lines, -5 lines 0 comments Download
A test/mjsunit/compiler/deopt-tonumber-compare.js View 1 chunk +44 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 3 chunks +2 lines, -1330 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-13 07:01:31 UTC) #1
Benedikt Meurer
Hey Jaro, This is the CL we're working on this morning. Thanks for helping. Please ...
5 years, 7 months ago (2015-05-13 07:02:11 UTC) #2
Jarin
lgtm with a nit. https://codereview.chromium.org/1140583004/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1140583004/diff/1/src/compiler/js-typed-lowering.cc#newcode480 src/compiler/js-typed-lowering.cc:480: #endif Delete the ifdef-ed block, ...
5 years, 7 months ago (2015-05-13 07:11:07 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1140583004/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1140583004/diff/1/src/compiler/js-typed-lowering.cc#newcode480 src/compiler/js-typed-lowering.cc:480: #endif On 2015/05/13 07:11:07, jarin wrote: > Delete the ...
5 years, 7 months ago (2015-05-13 07:15:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140583004/40001
5 years, 7 months ago (2015-05-13 07:17:34 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 07:38:48 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 07:38:57 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2111d18dbad8ce14124d69488aa3568dd4604768
Cr-Commit-Position: refs/heads/master@{#28383}

Powered by Google App Engine
This is Rietveld 408576698