Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1140583003: Material PDF: Add required Polymer 0.8 elements. (Closed)

Created:
5 years, 7 months ago by tsergeant
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, michaelpg+watch-polymer_chromium.org, oshima+watch_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Add required Polymer 0.8 elements. Adds paper-fab, paper-toolbar and polymer/layout, which are required by the material PDF viewer. Also adds required files from existing components to polymer_resources. BUG=482793 Committed: https://crrev.com/0e0f15b00b0faf5174839811d23a5a890ee2bbe1 Cr-Commit-Position: refs/heads/master@{#329787}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1092 lines, -138 lines) Patch
M third_party/polymer/v0_8/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v0_8/bower.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/layout/.bower.json View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/layout/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/layout/bower.json View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/layout/layout.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/v0_8/components-chromium/layout/shadow-layout.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-fab/.bower.json View 2 chunks +16 lines, -16 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-fab/README.md View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-fab/bower.json View 2 chunks +10 lines, -11 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-fab/index.html View 1 chunk +1 line, -3 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-fab/paper-fab.html View 1 chunk +117 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-fab/paper-fab-extracted.js View 1 1 chunk +27 lines, -5 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-toolbar/.bower.json View 1 2 chunks +12 lines, -17 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-toolbar/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-toolbar/bower.json View 1 2 chunks +9 lines, -16 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-toolbar/index.html View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-toolbar/paper-toolbar.html View 1 chunk +181 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-toolbar/paper-toolbar-extracted.js View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/layout/.bower.json View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/layout/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/layout/bower.json View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components/layout/layout.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/v0_8/components/layout/shadow-layout.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-fab/.bower.json View 2 chunks +16 lines, -16 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-fab/README.md View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/v0_8/components/paper-fab/bower.json View 2 chunks +10 lines, -11 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-fab/index.html View 1 chunk +1 line, -3 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-fab/paper-fab.html View 1 chunk +172 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-toolbar/.bower.json View 1 2 chunks +12 lines, -17 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-toolbar/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-toolbar/bower.json View 1 2 chunks +9 lines, -16 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-toolbar/index.html View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-toolbar/paper-toolbar.html View 1 chunk +278 lines, -0 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 4 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tsergeant
michaelpg@, can you please take a look?
5 years, 7 months ago (2015-05-13 06:39:20 UTC) #4
michaelpg
lgtm, just do a rebase (we added paper-icon-button and paper-item yesterday)
5 years, 7 months ago (2015-05-13 14:30:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140583003/20001
5 years, 7 months ago (2015-05-14 01:04:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 02:48:45 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 02:49:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e0f15b00b0faf5174839811d23a5a890ee2bbe1
Cr-Commit-Position: refs/heads/master@{#329787}

Powered by Google App Engine
This is Rietveld 408576698