Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chromecast/media/media.gyp

Issue 1140583002: Adds new libcast_media shared library for cast_shell media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor reformat in media.gyp Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/media.gyp
diff --git a/chromecast/media/media.gyp b/chromecast/media/media.gyp
index 7aa3d5ba06b5133e7e3cf2b79ebc39f37507977b..39c98c8a6a79efa3a9280f1129943d5864594be1 100644
--- a/chromecast/media/media.gyp
+++ b/chromecast/media/media.gyp
@@ -6,6 +6,8 @@
'variables': {
'chromium_code': 1,
'chromecast_branding%': 'Chromium',
+ 'enable_default_cast_media%': 1,
lcwu1 2015/05/13 01:58:24 nit: I would probably change the gyp var name slig
halliwell 2015/05/13 03:43:33 I think I was going for consistency with the graph
+ 'libcast_media_gyp%': '',
gunsch 2015/05/13 03:26:04 I just noticed libcast_graphics does the same thin
halliwell 2015/05/13 03:43:33 We should discuss for sure. The challenge is with
},
'targets': [
{
@@ -15,6 +17,7 @@
'../../base/base.gyp:base',
'../../crypto/crypto.gyp:crypto',
'../../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
+ '<(libcast_media_gyp):libcast_media_1.0',
],
'sources': [
'base/decrypt_context.cc',
@@ -294,5 +297,24 @@
'cma/test/run_all_unittests.cc',
],
},
+ ], # end of targets
+ 'conditions': [
+ ['enable_default_cast_media==1', {
+ 'targets': [
+ {
+ 'target_name': 'libcast_media_1.0',
+ 'type': 'shared_library',
+ 'dependencies': [
+ '../../chromecast/chromecast.gyp:cast_public_api'
+ ],
+ 'include_dirs': [
+ '../..',
+ ],
+ 'sources': [
+ 'base/cast_media_default.cc',
+ ],
+ }
+ ]
+ }],
],
}

Powered by Google App Engine
This is Rietveld 408576698