Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1140563003: clean up tests (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clean up tests Confirm that no path ops tests are flaky, and clean up errors around that. The test framework was incorrectly checking for >= MAX_ERRORS for failure and <= MAX_ERRORS for success. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/38a017bf44aa1ad25291ad0cbb4ccbe8bd31ab0b

Patch Set 1 #

Patch Set 2 : fix linux build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M tests/PathOpsExtendedTest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 5 chunks +10 lines, -27 lines 0 comments Download
M tests/PathOpsFuzz763Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpCircleThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpLoopThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpRectThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140563003/1
5 years, 7 months ago (2015-05-13 17:00:44 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1031) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 7 months ago (2015-05-13 17:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140563003/20001
5 years, 7 months ago (2015-05-13 17:07:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:13:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/38a017bf44aa1ad25291ad0cbb4ccbe8bd31ab0b

Powered by Google App Engine
This is Rietveld 408576698