tools/metrics/histograms/histograms.xml - Issue 1140443002: Modify IPC call to properly record the PLT histograms for LoFi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1140443002: Modify IPC call to properly record the PLT histograms for LoFi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 72268b81979ad9a2ae4418beb1cf0f45d5e216a3..1e85fb6e8d663eed9d826cf24c09ca9acab3fd1e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -66046,6 +66046,26 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PLT.PT_StartToFinish"/>

</histogram_suffixes>

+<histogram_suffixes name="DataReductionProxy_AutoLoFi" separator="_">

+ <suffix name="DataReductionProxy_AutoLoFiOn"

+ label="Only page loads through the data reduction proxy with auto LoFi

+ enabled are considered."/>

+ <suffix name="HTTPS_DataReductionProxy_AutoLoFiOn"

Alexei Svitkine (slow) 2015/05/12 21:55:09 Nit: Order the two HTTPS ones together?

tbansal1 2015/05/12 22:12:42 Done.

+ label="Only page loads through the data reduction proxy through an HTTP

+ tunnel for HTTPS origins with auto LoFi enabled are considered."/>

+ <suffix name="DataReductionProxy_AutoLoFiOff"

+ label="Only page loads through the data reduction proxy with auto LoFi

+ disabled are considered."/>

+ <suffix name="HTTPS_DataReductionProxy_Auto LoFiOff"

Alexei Svitkine (slow) 2015/05/12 21:55:09 Seems you have an extra space here?

tbansal1 2015/05/12 22:12:42 Done.

+ label="Only page loads through the data reduction proxy through an HTTP

+ tunnel for HTTPS origins with auto LoFi disabled are considered."/>

+ <affected-histogram name="PLT.PT_BeginToFinish"/>

+ <affected-histogram name="PLT.PT_CommitToFinish"/>

+ <affected-histogram name="PLT.PT_RequestToDomContentLoaded"/>

+ <affected-histogram name="PLT.PT_RequestToFinish"/>

+ <affected-histogram name="PLT.PT_StartToFinish"/>

+</histogram_suffixes>

<histogram_suffixes name="DataReductionProxy_TamperingFingerprints"

separator="_">

<suffix name="ChromeProxy"

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h ('k') | no next file » | no next file with comments »