Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc

Issue 1140443002: Modify IPC call to properly record the PLT histograms for LoFi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change the variable names to be more intuitive. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc
diff --git a/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc b/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc
index ed2cd4d40c8c752c3435888b2449d58120f1eb69..e942525cf112d2582a32a0642d4f20a7aa01b9de 100644
--- a/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc
+++ b/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc
@@ -28,8 +28,8 @@ bool DataReductionProxyMessageFilter::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(DataReductionProxyMessageFilter, message)
- IPC_MESSAGE_HANDLER(DataReductionProxyViewHostMsg_IsDataReductionProxy,
- OnIsDataReductionProxy)
+ IPC_MESSAGE_HANDLER(DataReductionProxyViewHostMsg_DataReductionProxyStatus,
+ OnDataReductionProxyStatus)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -38,17 +38,24 @@ bool DataReductionProxyMessageFilter::OnMessageReceived(
void DataReductionProxyMessageFilter::OverrideThreadForMessage(
const IPC::Message& message, content::BrowserThread::ID* thread) {
if (message.type() ==
- DataReductionProxyViewHostMsg_IsDataReductionProxy::ID) {
+ DataReductionProxyViewHostMsg_DataReductionProxyStatus::ID) {
*thread = content::BrowserThread::IO;
}
}
-void DataReductionProxyMessageFilter::OnIsDataReductionProxy(
- const net::HostPortPair& proxy_server, bool* response) {
- if (config_)
- *response = config_->IsDataReductionProxy(proxy_server, nullptr);
- else
- *response = false;
+void DataReductionProxyMessageFilter::OnDataReductionProxyStatus(
+ const net::HostPortPair& proxy_server,
+ bool* is_data_reduction_proxy,
+ AutoLoFiStatus* lofi_response) {
jeremyim 2015/05/12 19:46:21 nit: lofi_status
tbansal1 2015/05/12 22:12:41 Done.
+ *is_data_reduction_proxy = false;
+ *lofi_response = AUTO_LOFI_STATUS_DISABLED;
+ if (!config_) {
+ return;
+ }
+ *is_data_reduction_proxy =
+ config_->IsDataReductionProxy(proxy_server, nullptr);
+ if (*is_data_reduction_proxy)
+ *lofi_response = config_->GetAutoLoFiStatus();
}
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698