components/data_reduction_proxy/content/common/data_reduction_proxy_messages.h - Issue 1140443002: Modify IPC call to properly record the PLT histograms for LoFi.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_reduction_proxy/content/common/data_reduction_proxy_messages.h

Issue 1140443002: Modify IPC call to properly record the PLT histograms for LoFi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change the variable names to be more intuitive. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc ('K') | « components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

	6 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_conf ig.h"

6 #include "content/public/common/common_param_traits.h"	7 #include "content/public/common/common_param_traits.h"

7 #include "ipc/ipc_message_macros.h"	8 #include "ipc/ipc_message_macros.h"

8 #include "net/base/host_port_pair.h"	9 #include "net/base/host_port_pair.h"

9	10

10 #define IPC_MESSAGE_START DataReductionProxyStart	11 #define IPC_MESSAGE_START DataReductionProxyStart

11	12

12 IPC_SYNC_MESSAGE_CONTROL1_1(	13 IPC_ENUM_TRAITS_MAX_VALUE(data_reduction_proxy::AutoLoFiStatus,

13 DataReductionProxyViewHostMsg_IsDataReductionProxy,	14 data_reduction_proxy::AUTO_LOFI_STATUS_ON);

	15

	16 IPC_SYNC_MESSAGE_CONTROL1_2(

	17 DataReductionProxyViewHostMsg_DataReductionProxyStatus,

14 net::HostPortPair /* proxy server */,	18 net::HostPortPair /* proxy server */,

15 bool /* true iff the proxy server is a Data Reduction Proxy */)	19 bool /* true iff the proxy server is a Data Reduction Proxy */,

	20 data_reduction_proxy::
	Tom Sepez 2015/05/12 19:46:20 nit: Don't break at the ::, comment on next line a nit: Don't break at the ::, comment on next line as needed. tbansal1 2015/05/12 22:12:42 Done. Show quoted text On 2015/05/12 19:46:20, Tom Sepez wrote: > nit: Don't break at the ::, comment on next line as needed. Done.
	21 AutoLoFiStatus /* set to the current Auto LoFi status */)

OLD	NEW