LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html - Issue 114043002: Fix issue with selection being lost when InsertListCommand changes the list type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html

Issue 114043002: Fix issue with selection being lost when InsertListCommand changes the list type. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/execCommand/insert-list-nested-with-orphaned-expected.txt ('k') | LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem-expected.txt » ('j') | Source/core/editing/InsertListCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html

diff --git a/LayoutTests/editing/execCommand/selection-after-insert-list.html b/LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html

similarity index 81%

copy from LayoutTests/editing/execCommand/selection-after-insert-list.html

copy to LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html

index 1d00ca1208d928171b57056460fb2556c503faf0..62f9396aa30f91009a1b99af7551ead77fbb5083 100644

--- a/LayoutTests/editing/execCommand/selection-after-insert-list.html

+++ b/LayoutTests/editing/execCommand/selection-after-switch-type-of-listitem.html

@@ -8,10 +8,11 @@

var selection = window.getSelection();

var range = document.createRange();

-range.setStart(document.getElementById('first').firstChild, 2);

+range.setStart(document.getElementById('second').firstChild, 0);

range.setEnd(document.getElementById('second').firstChild, 3);

selection.addRange(range);

document.execCommand('InsertOrderedList', false, null);

+document.execCommand('InsertUnOrderedList', false, null);

yosin_UTC9 2013/12/13 01:10:41 nit: we don't need to specify |false| and |null|.

Markup.description("This tests verifies that the selection is properly reset after executing the command.");

Markup.dump('test');

</script>