mac: Turn on partial availability warning.

mac: Turn on partial availability warning.

When compiling Objective C, warns if a method is used whose availability is
newer than the deployment target.

BUG=471823
Committed: https://crrev.com/7943910c269820ce6ecab228a3bc1c8f7dc70689
Cr-Commit-Position: refs/heads/master@{#330573}

[erikchen, 2015-05-19 00:54:36]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2015-05-19 00:54:36]

thakis: Please review.

[Nico, 2015-05-19 00:58:20]

congrats!

https://codereview.chromium.org/1140423002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1140423002/diff/1/build/common.gypi#newcode2573
build/common.gypi:2573: '-Wpartial-availability',
We probably want to do this in some OS==mac section so that it isn't set for iOS
– this would confuse Xcode's clang and is probably not desired for iOS builds
with chromium's clang either

(also not needed on linux and windows where it won't do anything)

[erikchen, 2015-05-19 01:32:25]

https://codereview.chromium.org/1140423002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1140423002/diff/1/build/common.gypi#newcode2573
build/common.gypi:2573: '-Wpartial-availability',
On 2015/05/19 00:58:20, Nico wrote:
> We probably want to do this in some OS==mac section so that it isn't set for
iOS
> – this would confuse Xcode's clang and is probably not desired for iOS builds
> with chromium's clang either
> 
> (also not needed on linux and windows where it won't do anything)

Ah - hadn't considered the effect on iOS. Done.

[Nico, 2015-05-19 01:40:32]

lgtm, but:

https://codereview.chromium.org/1140423002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1140423002/diff/20001/build/common.gypi#newco...
build/common.gypi:2584: 'variables': { 'clang_warning_flags':
['-Wpartial-availability']},
If this is only for mac anyways, you could instead also do

  xcode_settings: { WARNING_CFLAGS: [-Wpartial-availability]}

which is what clang_warning_flags gets translated to here. (The point of
clang_warning_flags is that it sets the flag correctly for mac windows linux
android)

[erikchen, 2015-05-19 17:06:20]

thanks for the explanation. I appreciate that you take the time to explain the
right thing to me rather than just going ahead and writing the CL yourself. :)

https://codereview.chromium.org/1140423002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1140423002/diff/20001/build/common.gypi#newco...
build/common.gypi:2584: 'variables': { 'clang_warning_flags':
['-Wpartial-availability']},
On 2015/05/19 01:40:31, Nico (afk until Thu May 21) wrote:
> If this is only for mac anyways, you could instead also do
> 
>   xcode_settings: { WARNING_CFLAGS: [-Wpartial-availability]}
> 
> which is what clang_warning_flags gets translated to here. (The point of
> clang_warning_flags is that it sets the flag correctly for mac windows linux
> android)

Done.

[erikchen, 2015-05-19 17:06:23]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-05-19 17:06:23]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1140423002/#ps40001
(title: "Comments from thakis, round two.")

[commit-bot: I haz the power, 2015-05-19 17:09:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140423002/40001

[commit-bot: I haz the power, 2015-05-19 18:41:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-19 18:42:46]

Patchset 3 (id:??) landed as
https://crrev.com/7943910c269820ce6ecab228a3bc1c8f7dc70689
Cr-Commit-Position: refs/heads/master@{#330573}

[Nico, 2015-05-19 22:49:28]

I just realized that you probably want to do this in some .gn file (
cs.chromium.org for "\-wno-deprecated file:\.gn" will probably did you the
right file). Sorry about the delayed comment!
On May 19, 2015 11:42 AM, "'I haz the power ' via codereview.chromium.org" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 3 (id:??) landed as
> https://crrev.com/7943910c269820ce6ecab228a3bc1c8f7dc70689
> Cr-Commit-Position: refs/heads/master@{#330573}
>
> https://codereview.chromium.org/1140423002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-05-21 18:05:36]

https://code.google.com/p/chromium/codesearch#chromium/src/build/config/compi...
is probably a good place. (But you probably also need to check if (!is_nacl)
there because nacl's compiler won't know or need that flag)