Update some spinners on ChromeOS

Update some spinners on ChromeOS

1) file manager's chrome web store widget
2) wallpaper gallery spinner

BUG=485779
Committed: https://crrev.com/418d15324a67c22e2d7cf43b9a0dc6fe4d27fec5
Cr-Commit-Position: refs/heads/master@{#330559}

[Evan Stade, 2015-05-18 23:36:45]

estade@chromium.org changed reviewers:
+ yoshiki@chromium.org

[Evan Stade, 2015-05-18 23:36:45]

I'm not sure how or if 2x/spinner.png is used. Is it OK to remove it? Will it
safely fallback to spinner.svg in the parent directory?

[yoshiki, 2015-05-19 02:15:20]

yoshiki@chromium.org changed reviewers:
+ bshe@chromium.org, tbarzic@chromium.org

[yoshiki, 2015-05-19 02:15:21]

+bshe -- an owner of wallpaper manager
+tbarzic -- an active owner of webstore widget

[yoshiki, 2015-05-19 02:30:51]

https://codereview.chromium.org/1140403002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

https://codereview.chromium.org/1140403002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:132:
background: url(../images/ui/spinner.svg) center/32px no-repeat;
I think we can refer and use "chrome://resources/images/throbber.svg" instead of
embedding spinner.svg.

We may also need to add CSP section in manifest.json to refer external content.

https://codereview.chromium.org/1140403002/diff/1/components/chrome_apps/webs...
File components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.css
(right):

https://codereview.chromium.org/1140403002/diff/1/components/chrome_apps/webs...
components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.css:16:
background: url(spinner.svg) center / 32px no-repeat;
ditto.

[Evan Stade, 2015-05-19 16:36:41]

https://codereview.chromium.org/1140403002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

https://codereview.chromium.org/1140403002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:132:
background: url(../images/ui/spinner.svg) center/32px no-repeat;
On 2015/05/19 02:30:50, yoshiki wrote:
> I think we can refer and use "chrome://resources/images/throbber.svg" instead
of
> embedding spinner.svg.
> 
> We may also need to add CSP section in manifest.json to refer external
content.

thanks. Both references updated.

https://codereview.chromium.org/1140403002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/wallpaper_manager/manifest.json (right):

https://codereview.chromium.org/1140403002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/wallpaper_manager/manifest.json:7: "version":
"0.2",
we don't need to bump this, do we?

[tbarzic, 2015-05-19 16:44:30]

https://codereview.chromium.org/1140403002/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/manifest.json (left):

https://codereview.chromium.org/1140403002/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/manifest.json:15:
"cws_widget/cws_widget_container_error_dialog.js",
can you also remove this from
components/chrome_apps/webstore_widget_resources.grdp

[bshe, 2015-05-19 16:44:52]

lgtm

2x is automatically used for high dpi screen. Would you mind to verify the
quality of the throbbed on pixel before submit? Since it is a svg now, we should
be fine but it is safer to double check.

https://codereview.chromium.org/1140403002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/wallpaper_manager/manifest.json (right):

https://codereview.chromium.org/1140403002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/wallpaper_manager/manifest.json:7: "version":
"0.2",
On 2015/05/19 16:36:41, Evan Stade wrote:
> we don't need to bump this, do we?

no need to bump it.

[Evan Stade, 2015-05-19 17:39:45]

> Would you mind to verify the
> quality of the throbbed on pixel before submit? Since it is 
> a svg now, we should
> be fine but it is safer to double check.

looks good with --force-device-scale-factor=2.0

https://codereview.chromium.org/1140403002/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/manifest.json (left):

https://codereview.chromium.org/1140403002/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/manifest.json:15:
"cws_widget/cws_widget_container_error_dialog.js",
On 2015/05/19 16:44:30, tbarzic wrote:
> can you also remove this from
> components/chrome_apps/webstore_widget_resources.grdp

Done.

[tbarzic, 2015-05-19 17:56:40]

lgtm

[Evan Stade, 2015-05-19 17:56:54]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-05-19 17:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1140403002/#ps40001
(title: "fix csp")

[commit-bot: I haz the power, 2015-05-19 17:58:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140403002/40001

[commit-bot: I haz the power, 2015-05-19 18:12:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-19 18:13:19]

Patchset 3 (id:??) landed as
https://crrev.com/418d15324a67c22e2d7cf43b9a0dc6fe4d27fec5
Cr-Commit-Position: refs/heads/master@{#330559}