Fix result type checking of redirecting factory in checked mode (issue 6596).

tests/language/language_dart2js.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 [ $compiler == dart2js || $compiler == dart2dart ]
 class_literal_test/01: Fail # Class literals are expression now; delete this test.
 class_literal_test/02: Fail # Class literals are expression now; delete this test.
 class_literal_test/05: Fail # Class literals are expression now; delete this test.
 class_literal_test/06: Fail # Class literals are expression now; delete this test.
 class_literal_test/07: Fail # Class literals are expression now; delete this test.
@@ skipping 53 matching lines @@
 type_parameter_test/03: Fail # Issue 4932
 type_parameter_test/04: Fail # Issue 4932
 
 super_call4_test: Fail # Badly generated noSuchMethod call.
 
 [ $compiler == dart2js && $unchecked ]
 assertion_test: Fail
 new_expression_type_args_test/02: Fail # Test does not conform with spec.
 factory_redirection_test/08: Fail
 factory_redirection_test/09: Fail
+factory_redirection_test/10: Fail
+factory_redirection_test/11: Fail
+factory_redirection_test/12: Fail
+factory_redirection_test/13: Fail
+factory_redirection_test/14: Fail
 
 # Only checked mode reports an error on type assignment
 # problems in compile time constants.
 compile_time_constant_checked_test/02: Fail, OK
 compile_time_constant_checked2_test/01: Fail, OK
 compile_time_constant_checked2_test/02: Fail, OK
 compile_time_constant_checked2_test/03: Fail, OK
 compile_time_constant_checked2_test/04: Fail, OK
 compile_time_constant_checked2_test/05: Fail, OK
 compile_time_constant_checked2_test/06: Fail, OK
 compile_time_constant_checked3_test/01: Fail, OK
 compile_time_constant_checked3_test/02: Fail, OK
 compile_time_constant_checked3_test/03: Fail, OK
 compile_time_constant_checked3_test/04: Fail, OK
 compile_time_constant_checked3_test/05: Fail, OK
 compile_time_constant_checked3_test/06: Fail, OK
 
 [ $compiler == dart2js ]
 arithmetic_test: Fail # http://dartbug.com/6627
-factory_redirection_test/none: Fail
 factory_redirection_test/01: Fail
-factory_redirection_test/02: Fail
-factory_redirection_test/03: Fail
+factory_redirection_test/02: Crash

[ahe, 2012/11/19 10:26:02]

It would be great if you could report a bug when you find a crash in dart2js.

[regis, 2012/11/19 17:32:26]

I did not, because several bugs are already filed against factory redirection
support in dart2js (incl. one crash bug), and because many
factory_redirection_test are failing. But this is done now:
issue 6799.

[ahe, 2012/11/19 17:50:11]

Thank you, Regis, I wasn't aware of any crashes until I filed 6791 earlier
today.  Would you mind pointing me to the other ones as I want to bump their
priority?

+factory_redirection_test/03: Crash
 factory_redirection_test/05: Fail
-factory_redirection_test/06: Fail
+factory_redirection_test/07: Fail
 final_variable_assignment_test/01: Fail
 final_variable_assignment_test/02: Fail
 final_variable_assignment_test/03: Fail
 final_variable_assignment_test/04: Fail
 bad_override_test/01: Fail
 bad_override_test/02: Fail
 const_locals_test: Fail
 const_nested_test: Fail
 bad_constructor_test/04: Fail # http://dartbug.com/5519
 bad_constructor_test/05: Fail # http://dartbug.com/5519
@@ skipping 259 matching lines @@
 [ $runtime == opera ]
 call_through_null_getter_test: Fail
 closure3_test: Fail
 execute_finally3_test: Fail
 method_invocation_test: Fail
 null_pointer_exception_test: Fail
 stack_overflow_test: Fail
 string_interpolate_npe_test: Fail
 closure_call_wrong_argument_count_negative_test: Skip
 label_test: Skip