Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140393002: Update more-routing for md-settings (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
Reviewers:
Jeremy Klein
CC:
chromium-reviews, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update more-routing for md-settings BUG=485381 R=jlklein@chromium.org Committed: https://crrev.com/df6c7a284e8d25fc0b45ff2a506a94f4b383b0d2 Cr-Commit-Position: refs/heads/master@{#330452}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -5001 lines) Patch
M third_party/polymer/v0_8/components-chromium/more-routing/.bower.json View 2 chunks +10 lines, -14 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/bower.json View 1 chunk +6 lines, -10 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/more-routing/emitter.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/v0_8/components-chromium/more-routing/emitter-extracted.js View 1 chunk +68 lines, -0 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/more-route.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/more-route-extracted.js View 1 chunk +13 lines, -12 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/more-route-selection.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/more-route-selection-extracted.js View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/more-route-selector-extracted.js View 2 chunks +18 lines, -2 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/more-routing/more-route-template-helpers.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/more-routing/more-route-template-helpers-extracted.js View 1 chunk +22 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/more-routing/params.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/more-routing/params-extracted.js View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/route.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v0_8/components-chromium/more-routing/route-extracted.js View 6 chunks +37 lines, -6 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/.bower.json View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/README.md View 1 chunk +0 lines, -203 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/bower.json View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/codereview.settings View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/gruntfile.js View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/index.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/observe-js.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/package.json View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/src/observe.js View 1 chunk +0 lines, -1711 lines 0 comments Download
D third_party/polymer/v0_8/components-chromium/observe-js/util/planner.js View 1 chunk +0 lines, -309 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/.bower.json View 2 chunks +10 lines, -14 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/bower.json View 1 chunk +6 lines, -10 lines 0 comments Download
A third_party/polymer/v0_8/components/more-routing/emitter.html View 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/more-route.html View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/more-route-selection.html View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/more-route-selector.html View 2 chunks +18 lines, -2 lines 0 comments Download
A + third_party/polymer/v0_8/components/more-routing/more-route-template-helpers.html View 1 chunk +15 lines, -9 lines 0 comments Download
A third_party/polymer/v0_8/components/more-routing/params.html View 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/polymer/v0_8/components/more-routing/route.html View 7 chunks +39 lines, -7 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/.bower.json View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/README.md View 1 chunk +0 lines, -203 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/bower.json View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/codereview.settings View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/gruntfile.js View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/index.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/observe-js.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/package.json View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/src/observe.js View 1 chunk +0 lines, -1711 lines 0 comments Download
D third_party/polymer/v0_8/components/observe-js/util/planner.js View 1 chunk +0 lines, -309 lines 0 comments Download
M third_party/polymer/v0_8/reproduce.sh View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaelpg
This removes observe-js as well.
5 years, 7 months ago (2015-05-18 22:53:04 UTC) #4
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-18 22:54:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140393002/60001
5 years, 7 months ago (2015-05-18 22:58:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 7 months ago (2015-05-19 00:01:01 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:01:57 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/df6c7a284e8d25fc0b45ff2a506a94f4b383b0d2
Cr-Commit-Position: refs/heads/master@{#330452}

Powered by Google App Engine
This is Rietveld 408576698