Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1140383002: fix builder winding again (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix builder winding again Record the nesting level when finding the edge winding contribution so that inner edges can be reversed as needed. R=fmalita@chromium.org BUG=skia:3838 Committed: https://skia.googlesource.com/skia/+/4e1a4c9399b8bb0897218f3ec10c254d3bb97463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -755 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 4 chunks +16 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsWinding.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 4 chunks +25 lines, -7 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/pathops_visualizer.htm View 2 chunks +83 lines, -745 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140383002/1
5 years, 7 months ago (2015-05-18 17:09:35 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-18 17:09:36 UTC) #3
f(malita)
LGTM, assuming the pathops_visualizer.htm change is intentional.
5 years, 7 months ago (2015-05-18 17:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140383002/1
5 years, 7 months ago (2015-05-18 17:31:39 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 19:57:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4e1a4c9399b8bb0897218f3ec10c254d3bb97463

Powered by Google App Engine
This is Rietveld 408576698