Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 1140363002: Revert of Reland: Lazily initialize MessageLoop for faster thread startup (Closed)

Created:
5 years, 7 months ago by Alexander Potapenko
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, sadrul, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, asvitkine+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org, Takashi Toyoshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Lazily initialize MessageLoop for faster thread startup (patchset #5 id:160001 of https://codereview.chromium.org/1129953004/) Reason for revert: Massive data race reports, see https://crbug.com/489263 Original issue's description: > Reland: Lazily initialize MessageLoop for faster thread startup > > Original review: https://codereview.chromium.org/1011683002/ > > Reverted because it's suspected for following flakiness issues: > http://crbug.com/485157 - Windows race > http://crbug.com/485091 - Android ThreadWatcher > http://crbug.com/485178 - interactive_ui_tests Menu* tests > > PS1 is the original patch set that gets reverted. > > BUG=465458, 485157, 485091, 485178 > TBR=jam > > Committed: https://crrev.com/8b6133a69f16702a32a3c3104630c4d9ac393b7a > Cr-Commit-Position: refs/heads/master@{#330329} TBR=thakis@chromium.org,toyoshim@chromium.org,jam@chromium.org,kinuko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465458, 485157, 485091, 485178 Committed: https://crrev.com/787e3347eb49a59db5e6fe0374f50464f36d48e3 Cr-Commit-Position: refs/heads/master@{#330351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -300 lines) Patch
M base/message_loop/incoming_task_queue.h View 3 chunks +0 lines, -10 lines 0 comments Download
M base/message_loop/incoming_task_queue.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M base/message_loop/message_loop.h View 5 chunks +8 lines, -37 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +33 lines, -47 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M base/threading/platform_thread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/threading/thread.h View 6 chunks +12 lines, -25 lines 0 comments Download
M base/threading/thread.cc View 7 chunks +97 lines, -109 lines 0 comments Download
M base/threading/thread_id_name_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/public/browser/browser_thread_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/test_browser_thread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/test_browser_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/android/network_change_notifier_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Reland: Lazily initialize MessageLoop for faster thread startup
5 years, 7 months ago (2015-05-18 13:23:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140363002/1
5 years, 7 months ago (2015-05-18 13:23:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 13:24:30 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 13:25:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/787e3347eb49a59db5e6fe0374f50464f36d48e3
Cr-Commit-Position: refs/heads/master@{#330351}

Powered by Google App Engine
This is Rietveld 408576698