Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1140353002: Add --download-data-only option to run-test.py (Closed)

Created:
5 years, 7 months ago by bradnelson
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add --download-data-only option to run-test.py The simd.js benchmarks reside in the same repository that holds the compliance tests. Adding an option to run-test.py to download test data and exit, so that a recipe to run the simd.js benchmarks can call run-test.py with this option to fetch the test data. BUG=https://code.google.com/p/v8/issues/detail?id=4124 LOG=N TEST=manual verification it works. NOTRY=true R=machenbach@chromium.org Committed: https://crrev.com/f3a18ee6626fd838cf141b2364f350ecec79fb03 Cr-Commit-Position: refs/heads/master@{#28446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/run-tests.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
bradnelson
5 years, 7 months ago (2015-05-18 13:11:59 UTC) #1
Michael Achenbach
LGTM - I've set LOG=n in the cl desc as we only add api changes ...
5 years, 7 months ago (2015-05-18 14:03:17 UTC) #2
Michael Achenbach
I've also set NOTRY...
5 years, 7 months ago (2015-05-18 14:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140353002/1
5 years, 7 months ago (2015-05-18 14:09:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 14:11:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3a18ee6626fd838cf141b2364f350ecec79fb03 Cr-Commit-Position: refs/heads/master@{#28446}
5 years, 7 months ago (2015-05-18 14:11:37 UTC) #7
Michael Achenbach
5 years, 7 months ago (2015-05-18 14:18:34 UTC) #8
Message was sent while issue was closed.
FYI: It should work to write: BUG=v8:4124

Then bugdroid automatically adds the CL to the bug.

Powered by Google App Engine
This is Rietveld 408576698