Sync the SVGSVGElement interface with the spec

Source/core/svg/SVGSVGElement.idl

Index: Source/core/svg/SVGSVGElement.idl
diff --git a/Source/core/svg/SVGSVGElement.idl b/Source/core/svg/SVGSVGElement.idl
index dbfe07df0f30105b1e294f924801d9a18bdbc564..93df1c4b520436c628440f742e2948b36f1f97ca 100644
--- a/Source/core/svg/SVGSVGElement.idl
+++ b/Source/core/svg/SVGSVGElement.idl
@@ -29,14 +29,12 @@
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] readonly attribute SVGAnimatedLength y;
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] readonly attribute SVGAnimatedLength width;
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] readonly attribute SVGAnimatedLength height;
+    // TODO(philipj): viewport should be a DOMRectReadOnly.
     readonly attribute SVGRect viewport;
-    readonly attribute float pixelUnitToMillimeterX;
-    readonly attribute float pixelUnitToMillimeterY;
-    readonly attribute float screenPixelToMillimeterX;
-    readonly attribute float screenPixelToMillimeterY;
     readonly attribute boolean useCurrentView;
     readonly attribute SVGViewSpec currentView;
              attribute float currentScale;
+    // TODO(philipj): currentTranslate should be a DOMPointReadOnly.
     [ImplementedAs=currentTranslateFromJavascript] readonly attribute SVGPoint currentTranslate;
 
     [RuntimeEnabled=SVG1DOM, DeprecateAs=SVGSVGElementSuspendRedraw] unsigned long suspendRedraw(unsigned long maxWaitMilliseconds);
@@ -48,21 +46,30 @@
     boolean animationsPaused();
     float getCurrentTime();
     void setCurrentTime(float seconds);
+    // TODO(philipj): The rect arguments should be DOMRectReadOnly.
+    // TODO(philipj): The referenceElement arguments should not be nullable.

[fs, 2015/05/18 13:18:03]

I think this is a spec omission actually (this argument adds an additional
restriction to the result, and null is mentioned in the prose), so might be
worthwhile to add something mentioning that.

[philipj_slow, 2015/05/18 13:34:49]

I reverted this bit and updated the description.

     NodeList getIntersectionList(SVGRect rect, SVGElement? referenceElement);
     NodeList getEnclosureList(SVGRect rect, SVGElement? referenceElement);
     boolean checkIntersection(SVGElement element, SVGRect rect);
     boolean checkEnclosure(SVGElement element, SVGRect rect);
     void deselectAll();
-
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGNumber createSVGNumber();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGLength createSVGLength();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGAngle createSVGAngle();
+    // TODO(philipj): SVGPoint/Matrix/Rect should be DOMPoint/Matrix/Rect.
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGPoint createSVGPoint();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGMatrix createSVGMatrix();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGRect createSVGRect();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGTransform createSVGTransform();
     [RuntimeEnabled=SVG1DOM, MeasureAs=SVG1DOM] SVGTransform createSVGTransformFromMatrix(SVGMatrix matrix);
-    Element getElementById(DOMString elementId);
+
+    // The following were part of SVG 1.1 but are gone from SVG 2:
+    // http://www.w3.org/TR/SVG/struct.html#InterfaceSVGSVGElement
+    [Measure] readonly attribute float pixelUnitToMillimeterX;
+    [Measure] readonly attribute float pixelUnitToMillimeterY;
+    [Measure] readonly attribute float screenPixelToMillimeterX;
+    [Measure] readonly attribute float screenPixelToMillimeterY;
+    [Measure] Element getElementById(DOMString elementId);
 };
 
 SVGSVGElement implements SVGFitToViewBox;