Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1140343002: Sync the SVGSVGElement interface with the spec (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, krit, arv+blink, vivekg_samsung, kouhei+svg_chromium.org, vivekg, f(malita), Inactive, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync the SVGSVGElement interface with the spec Add use counters for the bits that have been removed from SVG 2. The referenceElement arguments are not nullable in the spec, but that seems to be a spec problem: https://github.com/w3c/svgwg/issues/16 BUG=460722, 313655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195466

Patch Set 1 #

Total comments: 2

Patch Set 2 : undo referenceElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-18 13:03:16 UTC) #2
fs
lgtm w/ tiny request https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl File Source/core/svg/SVGSVGElement.idl (right): https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl#newcode50 Source/core/svg/SVGSVGElement.idl:50: // TODO(philipj): The referenceElement arguments ...
5 years, 7 months ago (2015-05-18 13:18:03 UTC) #3
philipj_slow
undo referenceElement
5 years, 7 months ago (2015-05-18 13:33:30 UTC) #4
philipj_slow
https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl File Source/core/svg/SVGSVGElement.idl (right): https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl#newcode50 Source/core/svg/SVGSVGElement.idl:50: // TODO(philipj): The referenceElement arguments should not be nullable. ...
5 years, 7 months ago (2015-05-18 13:34:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140343002/20001
5 years, 7 months ago (2015-05-18 13:35:24 UTC) #8
fs
On 2015/05/18 13:34:49, philipj_UTC2 wrote: > https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl > File Source/core/svg/SVGSVGElement.idl (right): > > https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl#newcode50 > ...
5 years, 7 months ago (2015-05-18 13:36:20 UTC) #9
philipj_slow
On 2015/05/18 13:36:20, fs wrote: > On 2015/05/18 13:34:49, philipj_UTC2 wrote: > > > https://codereview.chromium.org/1140343002/diff/1/Source/core/svg/SVGSVGElement.idl ...
5 years, 7 months ago (2015-05-18 13:38:00 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:12:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195466

Powered by Google App Engine
This is Rietveld 408576698