Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 114033002: DevTools: Capture async stacks for event listeners. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: deal with nested async calls Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index aceaae4e39a91fd124d0d23e9fa00a60d50ae3c8..5c827554bae08b51383694e1ed9264e85d4d4e00 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -708,8 +708,30 @@ void InspectorDebuggerAgent::didFireAnimationFrame()
m_asyncCallStackTracker.didFireAsyncCall();
}
+void InspectorDebuggerAgent::didAddEventListener(EventTarget* eventTarget, const AtomicString& eventType, EventListener* listener, bool useCapture)
+{
+ if (m_asyncCallStackTracker.isEnabled())
+ m_asyncCallStackTracker.didAddEventListener(eventTarget, eventType, listener, useCapture, scriptDebugServer().currentCallFrames());
+}
+
+void InspectorDebuggerAgent::didRemoveEventListener(EventTarget* eventTarget, const AtomicString& eventType, EventListener* listener, bool useCapture)
+{
yurys 2013/12/17 13:01:59 if (m_asyncCallStackTracker.isEnabled()) ?
aandrey 2013/12/17 13:07:48 This check is inside the AsyncCallStackTracker met
yurys 2013/12/18 09:20:11 You should be consistent in placing this check eit
aandrey 2013/12/18 09:32:09 Done. Moved them all to the Agent.
+ m_asyncCallStackTracker.didRemoveEventListener(eventTarget, eventType, listener, useCapture);
+}
+
+void InspectorDebuggerAgent::didRemoveAllEventListeners(EventTarget* eventTarget)
+{
+ m_asyncCallStackTracker.didRemoveAllEventListeners(eventTarget);
yurys 2013/12/17 13:01:59 ditto
+}
+
+void InspectorDebuggerAgent::willHandleEvent(EventTarget* eventTarget, const AtomicString& eventType, EventListener* listener, bool useCapture)
+{
+ m_asyncCallStackTracker.willHandleEvent(eventTarget, eventType, listener, useCapture);
yurys 2013/12/17 13:01:59 ditto
+}
+
void InspectorDebuggerAgent::didHandleEvent()
{
+ m_asyncCallStackTracker.didFireAsyncCall();
yurys 2013/12/17 13:01:59 and here
cancelPauseOnNextStatement();
}

Powered by Google App Engine
This is Rietveld 408576698