Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: Source/core/events/EventTarget.cpp

Issue 114033002: DevTools: Capture async stacks for event listeners. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/EventTarget.cpp
diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp
index 6e96b47c6cdb629eaa22301ecbc053100dc9a0d7..7ff8763ab12110472bdefcfe5065145d0acc4306 100644
--- a/Source/core/events/EventTarget.cpp
+++ b/Source/core/events/EventTarget.cpp
@@ -83,7 +83,12 @@ inline DOMWindow* EventTarget::executingWindow()
bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
- return ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture);
+ EventListener* eventListener = listener.get();
+ if (ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture)) {
+ InspectorInstrumentation::didAddEventListener(this, eventType, eventListener, useCapture);
+ return true;
+ }
+ return false;
}
bool EventTarget::removeEventListener(const AtomicString& eventType, EventListener* listener, bool useCapture)
@@ -96,6 +101,7 @@ bool EventTarget::removeEventListener(const AtomicString& eventType, EventListen
if (!d->eventListenerMap.remove(eventType, listener, useCapture, indexOfRemovedListener))
return false;
+ InspectorInstrumentation::didRemoveEventListener(this, eventType, listener, useCapture);
// Notify firing events planning to invoke the listener at 'index' that
// they have one less listener to invoke.
@@ -327,7 +333,7 @@ void EventTarget::fireEventListeners(Event* event, EventTargetData* d, EventList
if (!context)
break;
- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willHandleEvent(context, event);
+ InspectorInstrumentationCookie cookie = InspectorInstrumentation::willHandleEvent(this, event->type(), registeredListener.listener.get(), registeredListener.useCapture);
// To match Mozilla, the AT_TARGET phase fires both capturing and bubbling
// event listeners, even though that violates some versions of the DOM spec.
registeredListener.listener->handleEvent(context, event);
@@ -363,6 +369,7 @@ void EventTarget::removeAllEventListeners()
if (!d)
return;
d->eventListenerMap.clear();
+ InspectorInstrumentation::didRemoveAllEventListeners(this);
// Notify firing events planning to invoke the listener at 'index' that
// they have one less listener to invoke.
« no previous file with comments | « LayoutTests/inspector/debugger/async-callstack-expected.txt ('k') | Source/core/inspector/AsyncCallStackTracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698