Improve the default browser settings dialog for Win10

Improve the default browser settings dialog for Win10

On Win10 the current approach of SHOpenWithDialog is suboptimal. See
the bug for more details.

BUG=488774, 489803
Committed: https://crrev.com/8707fef05b454ec373cb05d8a9f815780281ad2b
Cr-Commit-Position: refs/heads/master@{#330596}

[cpu_(ooo_6.6-7.5), 2015-05-16 02:11:48]

cpu@chromium.org changed reviewers:
+ grt@chromium.org

[cpu_(ooo_6.6-7.5), 2015-05-16 02:12:29]

can you pls take a look asap. I might need to need to merge this into m44

[Shrikant Kelkar, 2015-05-16 02:48:37]

shrikant@chromium.org changed reviewers:
+ shrikant@chromium.org

[Shrikant Kelkar, 2015-05-16 02:48:37]

lgtm

[Will Harris, 2015-05-16 05:04:02]

drive by

https://codereview.chromium.org/1140293002/diff/1/chrome/installer/util/shell...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/1140293002/diff/1/chrome/installer/util/shell...
chrome/installer/util/shell_util.cc:884:
base::win::ScopedComPtr<IApplicationActivationManager> activator;
msdn says this needs shobjidl.h included

[cpu_(ooo_6.6-7.5), 2015-05-18 20:02:42]

I'll wait a bit for grt@ else I am sending this tru by the power of grayskull.

[cpu_(ooo_6.6-7.5), 2015-05-18 20:10:48]

oy, today is a Canada holiday. I'll wait until tomorrow.

[grt (UTC plus 2), 2015-05-19 14:57:47]

ShowMakeChromeDefaultSystemUI is expected to be a blocking call. If you land
this, please file a Win10 bug stating that:

- the "You're almost done!" dialog doesn't wait for the user to select a default
before going away and showing the first browser window.
- chrome://settings doesn't refresh the default browser state after the user
makes Chrome the default using this mechanism.

Also, please update the doc comment for ShowMakeChromeDefaultSystemUI in
shell_util.h to indicate that it doesn't wait around on Win10+.

LGTM in the sense that this is better than nothing, but it's not ideal.

https://codereview.chromium.org/1140293002/diff/20001/chrome/installer/util/s...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/1140293002/diff/20001/chrome/installer/util/s...
chrome/installer/util/shell_util.cc:881: // focused. This only works for Windows
8 and and. The appModelId
nit: "Windows 8 and and." -> "Windows 8 and 10." or something like that.

[cpu_(ooo_6.6-7.5), 2015-05-19 19:29:25]

all done. Submitting now.

https://codereview.chromium.org/1140293002/diff/20001/chrome/installer/util/s...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/1140293002/diff/20001/chrome/installer/util/s...
chrome/installer/util/shell_util.cc:881: // focused. This only works for Windows
8 and and. The appModelId
On 2015/05/19 14:57:47, grt wrote:
> nit: "Windows 8 and and." -> "Windows 8 and 10." or something like that.

Acknowledged.

[cpu_(ooo_6.6-7.5), 2015-05-19 19:39:44]

The CQ bit was checked by cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2015-05-19 19:39:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
shrikant@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1140293002/#ps60001
(title: "fix comment")

[commit-bot: I haz the power, 2015-05-19 19:41:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140293002/60001

[commit-bot: I haz the power, 2015-05-19 20:31:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 20:32:36]

Patchset 4 (id:??) landed as
https://crrev.com/8707fef05b454ec373cb05d8a9f815780281ad2b
Cr-Commit-Position: refs/heads/master@{#330596}