Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 1140243002: [Telemetry] Move record_wpr from telemetry/page to telemetry/ (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move record_wpr from telemetry/page to telemetry/ Since recording should work for all user_story, not just page. And the logic of record_wpr should be very similar to telemetry/benchmark_runner.py, we would want them to be a sibling in the directory hierarchy. BUG=470865 Committed: https://crrev.com/9afb144d4b1f0137b8cbd2055b45c406399885ba Cr-Commit-Position: refs/heads/master@{#330123}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -389 lines) Patch
M tools/perf/record_wpr View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +0 lines, -187 lines 0 comments Download
D tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 chunk +0 lines, -201 lines 0 comments Download
A + tools/telemetry/telemetry/record_wpr.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/record_wpr_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
5 years, 7 months ago (2015-05-15 16:09:49 UTC) #3
sullivan
lgtm
5 years, 7 months ago (2015-05-15 16:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140243002/20001
5 years, 7 months ago (2015-05-15 16:41:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-15 17:38:04 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 17:38:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9afb144d4b1f0137b8cbd2055b45c406399885ba
Cr-Commit-Position: refs/heads/master@{#330123}

Powered by Google App Engine
This is Rietveld 408576698