Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3773)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1140223003: [PermissionBubble] identical ctor across platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permbubble
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index b33ec488621ba561c59ebb17e5724564451745a7..05f7da8fe435416cf6e32c56951cbcfd0d97c84a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1278,7 +1278,8 @@ using content::WebContents;
if (newContents) {
if (!permissionBubbleCocoa_.get()) {
- permissionBubbleCocoa_.reset(new PermissionBubbleCocoa([self window]));
+ DCHECK(browser_.get());
+ permissionBubbleCocoa_.reset(new PermissionBubbleCocoa(browser_.get()));
}
manager = PermissionBubbleManager::FromWebContents(newContents);
if (manager)
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698