Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1140183002: Revert of Media Router GYP/GN cleanup (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Media Router GYP/GN cleanup (patchset #14 id:260001 of https://codereview.chromium.org/1136623003/) Reason for revert: Broke Linux bots on Chromium waterfall, see http://build.chromium.org/p/chromium/builders/Linux/builds/62091 http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=3231 The error in gclient runhooks is: gyp: Key 'dependencies' repeated at level 3 with key path 'targets.3' while reading /b/build/slave/Linux_x64/build/src/chrome/browser/media/router/media_router.gyp Not sure why this didn't show up on other bots or trybots. Original issue's description: > Media Router GYP/GN cleanup: > > - Refactor GYP and GN files to share source lists. > - Extract a proper test_support target. > - Fix upstream files with new target structure. > > BUG=461815, 464199, 464205 > > Committed: https://crrev.com/9c5e5781517823c18144b0bb5b66b66a1afd6733 > Cr-Commit-Position: refs/heads/master@{#330002} TBR=brettw@chromium.org,kmarshall@chromium.org,mfoltz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461815, 464199, 464205 Committed: https://crrev.com/680e2cbe12d71bafb3dc8128f651dbdd6fd84f5a Cr-Commit-Position: refs/heads/master@{#330009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -119 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 2 chunks +78 lines, -20 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 5 chunks +36 lines, -16 lines 0 comments Download
D chrome/browser/media/router/media_router.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
A chrome/browser/media/router/media_router_tests.gypi View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +3 lines, -17 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Media Router GYP/GN cleanup
5 years, 7 months ago (2015-05-15 01:17:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140183002/1
5 years, 7 months ago (2015-05-15 01:21:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 01:24:33 UTC) #3
mark a. foltz
lgtm
5 years, 7 months ago (2015-05-15 01:25:20 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:26:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/680e2cbe12d71bafb3dc8128f651dbdd6fd84f5a
Cr-Commit-Position: refs/heads/master@{#330009}

Powered by Google App Engine
This is Rietveld 408576698