Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 1140173003: Allow whitelisted content scripts to be injected in WebViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@document_has_focus
Patch Set: Don't assume extensions_->GetByID will succeed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 11aad869a7aecac6c732602ea8cbeebafeff2de0..43f68b924cfc13f792bb28c3f1cbeb0edef603f5 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -330,8 +330,6 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
content::NOTIFICATION_RESOURCE_RECEIVED_REDIRECT,
content::Source<WebContents>(web_contents()));
- if (web_view_guest_delegate_)
- web_view_guest_delegate_->OnDidInitialize();
AttachWebViewHelpers(web_contents());
rules_registry_id_ = GetOrGenerateRulesRegistryID(
@@ -786,11 +784,6 @@ void WebViewGuest::DidCommitProvisionalLoadForFrame(
new GuestViewEvent(webview::kEventLoadCommit, args.Pass()));
find_helper_.CancelAllFindSessions();
-
- if (web_view_guest_delegate_) {
- web_view_guest_delegate_->OnDidCommitProvisionalLoadForFrame(
- !render_frame_host->GetParent());
- }
}
void WebViewGuest::DidFailProvisionalLoad(
@@ -814,12 +807,6 @@ void WebViewGuest::DidStartProvisionalLoadForFrame(
new GuestViewEvent(webview::kEventLoadStart, args.Pass()));
}
-void WebViewGuest::DocumentLoadedInFrame(
- content::RenderFrameHost* render_frame_host) {
- if (web_view_guest_delegate_)
- web_view_guest_delegate_->OnDocumentLoadedInFrame(render_frame_host);
-}
-
void WebViewGuest::RenderProcessGone(base::TerminationStatus status) {
// Cancel all find sessions in progress.
find_helper_.CancelAllFindSessions();

Powered by Google App Engine
This is Rietveld 408576698