chrome/renderer/extensions/renderer_permissions_policy_delegate.cc - Issue 1140173003: Allow whitelisted content scripts to be injected in WebViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/renderer_permissions_policy_delegate.cc

Issue 1140173003: Allow whitelisted content scripts to be injected in WebViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@document_has_focus

Patch Set: Don't assume extensions_->GetByID will succeed Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/renderer_permissions_policy_delegate.cc

diff --git a/chrome/renderer/extensions/renderer_permissions_policy_delegate.cc b/chrome/renderer/extensions/renderer_permissions_policy_delegate.cc

index dabf649a49360e9b069f6e05c13927d38df8e013..58b1ed1336c3b86c0578b3dad17fa4029210e9bb 100644

--- a/chrome/renderer/extensions/renderer_permissions_policy_delegate.cc

+++ b/chrome/renderer/extensions/renderer_permissions_policy_delegate.cc

@@ -30,12 +30,8 @@ bool RendererPermissionsPolicyDelegate::CanExecuteScriptOnPage(

int tab_id,

int process_id,

std::string* error) {

- const ExtensionsClient::ScriptingWhitelist& whitelist =

- ExtensionsClient::Get()->GetScriptingWhitelist();

- if (std::find(whitelist.begin(), whitelist.end(), extension->id()) !=

- whitelist.end()) {

+ if (PermissionsData::CanExecuteScriptEverywhere(extension))

return true;

- }

if (dispatcher_->IsExtensionActive(kWebStoreAppId)) {

if (error)