Implement per-server ProofVerifyDetails in MockCryptoClientStreamFactory.

net/quic/test_tools/mock_crypto_client_stream_factory.h

Index: net/quic/test_tools/mock_crypto_client_stream_factory.h
diff --git a/net/quic/test_tools/mock_crypto_client_stream_factory.h b/net/quic/test_tools/mock_crypto_client_stream_factory.h
index b138c70ee87ee992d48b849035cc3217005b8fa7..dbe2422e3ef04218cf356670435d48a4f25c6871 100644
--- a/net/quic/test_tools/mock_crypto_client_stream_factory.h
+++ b/net/quic/test_tools/mock_crypto_client_stream_factory.h
@@ -5,6 +5,7 @@
 #ifndef NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_FACTORY_H_
 #define NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_FACTORY_H_
 
+#include <map>
 #include <string>
 
 #include "net/quic/quic_crypto_client_stream.h"
@@ -18,7 +19,7 @@ class QuicServerId;
 class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory  {
  public:
   MockCryptoClientStreamFactory();
-  ~MockCryptoClientStreamFactory() override {}
+  ~MockCryptoClientStreamFactory() override;
 
   QuicCryptoClientStream* CreateQuicCryptoClientStream(
       const QuicServerId& server_id,
@@ -30,9 +31,15 @@ class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory  {
     handshake_mode_ = handshake_mode;
   }
 
-  void set_proof_verify_details(
-      const ProofVerifyDetails* proof_verify_details) {
-    proof_verify_details_ = proof_verify_details;
+  void set_default_proof_verify_details(
+      const ProofVerifyDetails* default_proof_verify_details) {
+    default_proof_verify_details_ = default_proof_verify_details;
+  }
+
+  void set_proof_verify_details_for_server(

[Ryan Hamilton, 2015/05/15 04:21:21]

I'm not in love with having both "default" and "per server" details. I recommend
either
1) Always doing per-server
or
2) Having a queue of details (this matches what we do with SocketDataProviders)

either approach is fine with me. the first might be simpler since you already
have most of the code here.

[Bence, 2015/05/15 12:05:49]

Fair enough.  I choose the queue approach, because it's simpler, and as you
said, it matches SocketDataProviders behavior.

+      const ProofVerifyDetails* proof_verify_details,
+      const QuicServerId& server_id) {
+    proof_verify_details_map_[server_id] = proof_verify_details;
   }
 
   MockCryptoClientStream* last_stream() const {
@@ -42,7 +49,10 @@ class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory  {
  private:
   MockCryptoClientStream::HandshakeMode handshake_mode_;
   MockCryptoClientStream* last_stream_;
-  const ProofVerifyDetails* proof_verify_details_;
+  const ProofVerifyDetails* default_proof_verify_details_;
+  typedef std::map<QuicServerId, const ProofVerifyDetails*>
+      ProofVerifyDetailsMap;
+  ProofVerifyDetailsMap proof_verify_details_map_;
 
   DISALLOW_COPY_AND_ASSIGN(MockCryptoClientStreamFactory);
 };