Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java

Issue 1140163004: Do not register onLayoutListener unless it is needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
diff --git a/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java b/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
index 59108ce0fefcf6a919892ccbdccebeaa36ef2b55..c83a0cac60cc7f05dac183db393efd6c1663fb36 100644
--- a/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
+++ b/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
@@ -51,13 +51,26 @@ public class ActivityWindowAndroid
public ActivityWindowAndroid(Activity activity, boolean listenToActivityState) {
super(activity.getApplicationContext());
mActivityRef = new WeakReference<Activity>(activity);
- activity.findViewById(android.R.id.content).addOnLayoutChangeListener(this);
if (listenToActivityState) {
ApplicationStatus.registerStateListenerForActivity(this, activity);
}
}
@Override
+ protected void registerKeyboardVisibilityCallbacks() {
+ Activity activity = mActivityRef.get();
+ if (activity == null) return;
+ activity.findViewById(android.R.id.content).addOnLayoutChangeListener(this);
jdduke (slow) 2015/05/14 21:51:54 Can this fail on WebView? I guess we shouldn't be
boliu 2015/05/14 23:05:29 Hmm? What do you mean? These were running on webvi
+ }
+
+ @Override
+ protected void unregisterKeyboardVisibilityCallbacks() {
+ Activity activity = mActivityRef.get();
+ if (activity == null) return;
+ activity.findViewById(android.R.id.content).removeOnLayoutChangeListener(this);
+ }
+
+ @Override
public int showCancelableIntent(
PendingIntent intent, IntentCallback callback, Integer errorId) {
Activity activity = mActivityRef.get();

Powered by Google App Engine
This is Rietveld 408576698