base/base.gyp - Issue 1140153005: ICU msg format support with more than one arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark's review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index e9b09959da833589caffca378e963d4192989c5e..4a558d8db5cfc597f3733ffc3f989e629619c276 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -288,6 +288,8 @@

'export_dependent_settings': [

'base',

+ '../third_party/icu/icu.gyp:icuuc',

+ '../third_party/icu/icu.gyp:icui18n',

'includes': [

'../build/android/increase_size_for_speed.gypi',

@@ -483,6 +485,7 @@

'i18n/char_iterator_unittest.cc',

'i18n/file_util_icu_unittest.cc',

'i18n/icu_string_conversions_unittest.cc',

+ 'i18n/message_formatter_unittest.cc',

'i18n/number_formatting_unittest.cc',

'i18n/rtl_unittest.cc',

'i18n/streaming_utf8_validator_unittest.cc',

« no previous file with comments | « base/BUILD.gn ('k') | base/base.gypi » ('j') | no next file with comments »